Use llvm-libunwind="in-tree" for Fuchsia targets#100341
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 13, 2022
Merged
Use llvm-libunwind="in-tree" for Fuchsia targets#100341bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @jyn514 (rust-highfive has picked a reviewer for you, use r? to override) |
Member
|
Can you also update the target docs so they don't say you need to override this anymore? |
Removing libunwind from Fuchsia target docs
173ac65 to
29238f4
Compare
Member
Author
Good call -- done! |
Member
|
The bootstrap changes were already approved in #93604 (comment). @bors r+ rollup=never (broke last time) |
Collaborator
Collaborator
|
⌛ Testing commit 29238f4 with merge 24041dbeb7a469050367aa1d63309a708fc46af1... |
Collaborator
|
💥 Test timed out |
Member
|
@bors retry |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (e8dc8bc): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With updates to Fuchsia CI's Zircon libraries #99833, we can introduce
llvm-libunwind="in-tree"for Fuchsia targets. This PR restores functionality removed from #93604 (comment).cc @tmandry @djkoloski