Merged
Conversation
Also refactor iOS, watchOS and tvOS common code.
bootstrap panic when running x fmt --check. running x fmt --check
This issue was most likely fixed by rust-lang#93805.
For some reason, adding some text to match against makes this test pass. Before, when it was *more* general, it was failing! This seems very likely to be a bug in htmldocck, which I'm going to investigate.
…rochenkov Add support for link-flavor rust-lld for macOS Also refactor iOS, watchOS and tvOS common code. The ``-arch`` argument was moved to the ``apple_base`` module instead of the target definitions for macOS. As ld64 requires ``-syslibroot`` to be passed, ``add_apple_sdk`` was modified accordingly.
…r=eddyb Remove logic related to deprecated nvptx-nvidia-cuda (32-bit) target As described in the MCP rust-lang/compiler-team#496 (comment) r? ``@eddyb``
Fixes bootstrap panic when running x fmt --check closes rust-lang#100258 wherein bootstrap panics when running x fmt --check. Fixed by replacing resume_unwind in rust-lang#98994. with process::exit.
Add regression test for rust-lang#93205 Closes rust-lang#93205. This issue was most likely fixed by rust-lang#93805.
…son, r=lcnr Refactor: remove a type string comparison
Fix doc links in core::time::Duration::as_secs
… r=lcnr Special-case references to leafs in valtree pretty-printing Fixes rust-lang#100313
…checked-rt-impl, r=scottmcm
Inline CStr::from_bytes_with_nul_unchecked::rt_impl
Currently `CStr::from_bytes_with_nul_unchecked::rt_impl` is not being inlined. The following function:
```rust
pub unsafe fn from_bytes_with_nul_unchecked(bytes: &[u8]) {
CStr::from_bytes_with_nul_unchecked(bytes);
}
```
Outputs the following assembly on current nightly
```asm
example::from_bytes_with_nul_unchecked:
jmp qword ptr [rip + _ZN4core3ffi5c_str4CStr29from_bytes_with_nul_unchecked7rt_impl17h026f29f3d6a41333E@GOTPCREL]
```
Meanwhile on beta this provides the following assembly:
```asm
example::from_bytes_with_nul_unchecked:
ret
```
This pull request adds `#[inline]` annotation to`rt_impl` to fix a code generation regression for `CStr::from_bytes_with_nul_unchecked`.
rustbot
added
T-bootstrap
Contributor
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (7bc32fa): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Self::links are "not in scope" when used inimplblocks across modules #93205)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup