rustdoc: remove unused CSS .content .item-list#102744
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon. Please see the contribution instructions for more information. |
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Less CSS and less HTML. \o/ r=me once CI pass |
Since 50f662e, there is no CSS or JS targeting this class.
ea2144d to
0997b28
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Is https://github.com/rust-lang/rust/actions/runs/3199349362/jobs/5225001335#step:25:4065 an intermittent test failure? @GuillaumeGomez I can't reproduce the fail locally. |
|
Seems very unlikely since the DOM is fully loaded before this check is performed. How strange... Let's retry and if the CI pass, I'll add a mental note to check what happened. |
|
@GuillaumeGomez It passed. |
…ist, r=GuillaumeGomez rustdoc: remove unused CSS `.content .item-list` When these rules were added in 4fd061c (yeah, that's the very first commit of rustdoc_ng), `.item-list` was a `<ul>`, and this would override the default style for that tag. In c1b1d68, it was changed to use a `<div>` tag, so these rules are both no-ops.
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#102577 (Warn about Visual Studio Code branding confusion) - rust-lang#102720 (do not reverse the expected type and found type for ObligationCauseCo…) - rust-lang#102744 (rustdoc: remove unused CSS `.content .item-list`) - rust-lang#102747 (rustdoc: remove unused CSS `.docblock a:not(.srclink)`) - rust-lang#102748 (Disable compressed debug sections on i586-gnu) - rust-lang#102761 (let-else: test else block with non-never uninhabited type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…est, r=notriddle Update browser-ui-test version to fix some flaky tests Part of rust-lang#93784. It should fix the new spurious failure found in rust-lang#102744. r? `@notriddle`
…est, r=notriddle Update browser-ui-test version to fix some flaky tests Part of rust-lang#93784. It should fix the new spurious failure found in rust-lang#102744. r? ``@notriddle``
When these rules were added in 4fd061c (yeah, that's the very first commit of rustdoc_ng),
.item-listwas a<ul>, and this would override the default style for that tag.In c1b1d68, it was changed to use a
<div>tag, so these rules are both no-ops.