Adding Fuchsia compiler testing script, docs#103842
Conversation
rustbot
added
A-testsuite
andrewpollack
force-pushed
the
add-fuchsia-test-script
branch
2 times, most recently
from
f4e6f3d to
9faaa5e
Compare
andrewpollack
force-pushed
the
add-fuchsia-test-script
branch
from
9faaa5e to
cabffb7
Compare
There was a problem hiding this comment.
Does this work? As I recall, --test-args takes a single arg or a space separated list of args. But you would have to escape it to get the second behavior, e.g.
--test-args "--target-rustcflags -L"
--test-args "--target-rustcflags ${SDK_PATH}/arch/{x64|arm64}/sysroot/lib
What's going on here is you're passing an arg to pass to compiletest which is then specifying an arg to pass to rustc. So compiletest should see something like
--target-rustcflags -L --target-rustcflags ${SDK_PATH}/arch/{x64,arm64}/sysroot/lib
while rustc sees
-L ${SDK_PATH}/arch/{x64,arm64}/sysroot/lib
It's pretty gross :)
There was a problem hiding this comment.
This works, and is the only way to pass multiple --test-args in our current CI on Fuchsia. When using --test-args "", the double-quotes confuse the arg parsing and this is the only workaround
We could make upstream have a nicer-looking double-quote, but this will bring it out of line with our CI on Fuchsia
There was a problem hiding this comment.
Understood on the double quotes not working, but without them I would think you need
| --test-args --target-rustcflags -L \ | |
| --test-args --target-rustcflags \ | |
| --test-args -L |
If this somehow works I'm interested to know how, not that that needs to block this PR.
There was a problem hiding this comment.
Oh no -- I apologize! I completely misunderstood what you were saying -- yes, you are right on the need to add an additional --test-args. Creating a PR to fix now
andrewpollack
force-pushed
the
add-fuchsia-test-script
branch
from
cabffb7 to
e1636b8
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 13 pull requests Successful merges: - rust-lang#103842 (Adding Fuchsia compiler testing script, docs) - rust-lang#104354 (Remove leading newlines from `NonZero*` doc examples) - rust-lang#104372 (Update compiler-builtins) - rust-lang#104380 (rustdoc: remove unused CSS `code { opacity: 1 }`) - rust-lang#104381 (Remove dead NoneError diagnostic handling) - rust-lang#104383 (Remove unused symbols and diagnostic items) - rust-lang#104391 (Deriving cleanups) - rust-lang#104403 (Specify language of code comment to generate document) - rust-lang#104404 (Fix missing minification for static files) - rust-lang#104413 ([llvm-wrapper] adapt for LLVM API change) - rust-lang#104415 (rustdoc: fix corner case in search keyboard commands) - rust-lang#104422 (Fix suggest associated call syntax) - rust-lang#104426 (Add test for rust-lang#102154) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…-docs, r=tmandry Fuchsia test suite script fix Fixing error from rust-lang#103842 (comment) r? `@tmandry`
…-docs, r=tmandry Fuchsia test suite script fix Fixing error from rust-lang#103842 (comment) r? ``@tmandry``
…-docs, r=tmandry Fuchsia test suite script fix Fixing error from rust-lang#103842 (comment) r? ```@tmandry```
4 participants
Adding Fuchsia compiler testing script and related docs updates
r? @tmandry
cc. @djkoloski