Change the way libunwind is linked for *-windows-gnullvm targets#103894
Merged
bors merged 3 commits intorust-lang:masterfrom Nov 14, 2022
Merged
Change the way libunwind is linked for *-windows-gnullvm targets#103894bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
Collaborator
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
thomcc
reviewed
Nov 4, 2022
mati865
force-pushed
the
gnullvm-libunwind-changes
branch
from
abfd414 to
6507460
Compare
This fixes unwinding on `aarch64-*-windows-gnu*`.
mati865
force-pushed
the
gnullvm-libunwind-changes
branch
from
6507460 to
7333ee0
Compare
Member
|
This looks fine to me. @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (7b513af): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
mati865
added a commit
to mati865/rust
that referenced
this pull request
Nov 15, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 20, 2022
…ark-Simulacrum Fix building of `aarch64-pc-windows-gnullvm` That change had been lost during rebase of my last PR (rust-lang#103894).
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Nov 22, 2022
…md64, r=thomcc Reduce exceptions overallocation on non Windows x86_64 Addressing rust-lang#103894 (comment)
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…=thomcc Change the way libunwind is linked for *-windows-gnullvm targets I have no idea why previous way works for `x86_64-fortanix-unknown-sgx` (assuming it actually works...) but not for `gnullvm`. It fails when linking libtest during Rust build (unless somebody adds `RUSTFLAGS='-Clinkarg=-lunwind'`). Also fixes exception handling on AArch64.
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
Feb 10, 2023
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
Feb 10, 2023
…acrum Fix building of `aarch64-pc-windows-gnullvm` That change had been lost during rebase of my last PR (rust-lang/rust#103894).
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
Feb 10, 2023
…homcc Reduce exceptions overallocation on non Windows x86_64 Addressing rust-lang/rust#103894 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea why previous way works for
x86_64-fortanix-unknown-sgx(assuming it actually works...) but not forgnullvm. It fails when linking libtest during Rust build (unless somebody addsRUSTFLAGS='-Clinkarg=-lunwind').Also fixes exception handling on AArch64.