Issue error when -C link-self-contained option is used on unsupported platforms#104137

StackDoubleFlow · 2022-11-08T05:05:03Z

The documentation was also updated to reflect this.

I'm assuming the supported platforms are the same as initially written in RELEASES.md.

rustbot · 2022-11-08T05:05:10Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-11-08T05:05:13Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

compiler-errors · 2022-11-08T18:09:16Z

r? @petrochenkov

rustbot · 2022-11-08T18:09:17Z

Could not assign reviewer from: petrochenkov.
User(s) petrochenkov are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_error_messages/locales/en-US/codegen_ssa.ftl

rustbot · 2022-11-11T18:40:09Z

These commits modify compiler targets.
(See the Target Tier Policy.)

petrochenkov · 2022-11-11T20:03:44Z

Thanks!
r=me after squashing commits.
@rustbot author

StackDoubleFlow · 2022-11-11T20:24:48Z

@rustbot ready

petrochenkov · 2022-11-11T20:27:37Z

@bors r+

bors · 2022-11-11T20:27:39Z

📌 Commit f6d7f08 has been approved by petrochenkov

It is now in the queue for this repository.

…d, r=petrochenkov Issue error when -C link-self-contained option is used on unsupported platforms The documentation was also updated to reflect this. I'm assuming the supported platforms are the same as initially written in [RELEASES.md](https://github.com/rust-lang/rust/blob/master/RELEASES.md#compiler-17). Fixes rust-lang#103576

bjorn3 · 2022-11-14T14:27:38Z

@bors r+

bors · 2022-11-14T14:28:03Z

📌 Commit f280fd05cf09686677a8fe388bee51c0b837a984 has been approved by bjorn3

It is now in the queue for this repository.

bors · 2022-11-15T03:40:12Z

☔ The latest upstream changes (presumably #104091) made this pull request unmergeable. Please resolve the merge conflicts.

…ed platforms Document supported targets for `-C link-self-contained` Move `LinkSelfContainedDefault::True` from wasm_base to wasm32_wasi

bjorn3 · 2022-11-15T09:56:42Z

@bors r+

bors · 2022-11-15T09:56:44Z

📌 Commit 0b6dce4 has been approved by bjorn3

It is now in the queue for this repository.

…d, r=bjorn3 Issue error when -C link-self-contained option is used on unsupported platforms The documentation was also updated to reflect this. I'm assuming the supported platforms are the same as initially written in [RELEASES.md](https://github.com/rust-lang/rust/blob/master/RELEASES.md#compiler-17). Fixes rust-lang#103576

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#103750 (Fix some misleading target feature aliases) - rust-lang#104137 (Issue error when -C link-self-contained option is used on unsupported platforms) - rust-lang#104317 (cleanup and dedupe CTFE and Miri error reporting) - rust-lang#104335 (Only do parser recovery on retried macro matching) - rust-lang#104394 (various cleanups to try to reduce the use of spans inside method resolution) - rust-lang#104459 (rustdoc: remove unused JS IIFE from main.js) - rust-lang#104462 (rustdoc: remove pointless CSS `.rightside { padding-right: 2px }`) - rust-lang#104466 (rustdoc: remove no-op CSS `#crate-search-div { display: inline-block }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…d, r=bjorn3 Issue error when -C link-self-contained option is used on unsupported platforms The documentation was also updated to reflect this. I'm assuming the supported platforms are the same as initially written in [RELEASES.md](https://github.com/rust-lang/rust/blob/master/RELEASES.md#compiler-17). Fixes rust-lang#103576

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#103750 (Fix some misleading target feature aliases) - rust-lang#104137 (Issue error when -C link-self-contained option is used on unsupported platforms) - rust-lang#104317 (cleanup and dedupe CTFE and Miri error reporting) - rust-lang#104335 (Only do parser recovery on retried macro matching) - rust-lang#104394 (various cleanups to try to reduce the use of spans inside method resolution) - rust-lang#104459 (rustdoc: remove unused JS IIFE from main.js) - rust-lang#104462 (rustdoc: remove pointless CSS `.rightside { padding-right: 2px }`) - rust-lang#104466 (rustdoc: remove no-op CSS `#crate-search-div { display: inline-block }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned compiler-errors Nov 8, 2022

StackDoubleFlow force-pushed the err-lsc-unsupported branch from b7cfe69 to 4fb8d9f Compare November 8, 2022 05:24

petrochenkov self-assigned this Nov 8, 2022

compiler-errors removed their assignment Nov 8, 2022

petrochenkov reviewed Nov 10, 2022

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved

compiler/rustc_error_messages/locales/en-US/codegen_ssa.ftl Outdated Show resolved Hide resolved

StackDoubleFlow force-pushed the err-lsc-unsupported branch from 2307f44 to f6d7f08 Compare November 11, 2022 20:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2022

Manishearth mentioned this pull request Nov 11, 2022

Rollup of 10 pull requests #104305

Closed

rustbot assigned bjorn3 and unassigned petrochenkov Nov 14, 2022

petrochenkov removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 14, 2022

StackDoubleFlow force-pushed the err-lsc-unsupported branch from f3eb528 to f280fd0 Compare November 14, 2022 14:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2022

StackDoubleFlow force-pushed the err-lsc-unsupported branch from f280fd0 to 47e284c Compare November 15, 2022 04:10

Issue error when -C link-self-contained option is used on unsupport…

0b6dce4

…ed platforms Document supported targets for `-C link-self-contained` Move `LinkSelfContainedDefault::True` from wasm_base to wasm32_wasi

StackDoubleFlow force-pushed the err-lsc-unsupported branch from 47e284c to 0b6dce4 Compare November 15, 2022 04:21

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2022

matthiaskrgr mentioned this pull request Nov 16, 2022

Rollup of 9 pull requests #104489

Closed

matthiaskrgr mentioned this pull request Nov 16, 2022

Rollup of 8 pull requests #104492

Merged

bors merged commit fbcd751 into rust-lang:master Nov 16, 2022

rustbot added this to the 1.67.0 milestone Nov 16, 2022

StackDoubleFlow deleted the err-lsc-unsupported branch December 24, 2022 17:05

cuviper mentioned this pull request Mar 8, 2023

Linker invocation for wasm32-unknown-unknown incompatibly changed between 1.66.1 and 1.67.1 #108910

Open

Uh oh!

Conversation

StackDoubleFlow commented Nov 8, 2022

Uh oh!

rustbot commented Nov 8, 2022

Uh oh!

rustbot commented Nov 8, 2022

Uh oh!

compiler-errors commented Nov 8, 2022

Uh oh!

rustbot commented Nov 8, 2022

Uh oh!

Uh oh!

Uh oh!

rustbot commented Nov 11, 2022

Uh oh!

petrochenkov commented Nov 11, 2022

Uh oh!

StackDoubleFlow commented Nov 11, 2022

Uh oh!

petrochenkov commented Nov 11, 2022

Uh oh!

bors commented Nov 11, 2022

Uh oh!

bjorn3 commented Nov 14, 2022

Uh oh!

bors commented Nov 14, 2022

Uh oh!

bors commented Nov 15, 2022

Uh oh!

bjorn3 commented Nov 15, 2022

Uh oh!

bors commented Nov 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants