Set download-ci-llvm = "if-available" by default when channel = dev#104512
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 10, 2022
Merged
Set download-ci-llvm = "if-available" by default when channel = dev#104512bors merged 1 commit intorust-lang:masterfrom
download-ci-llvm = "if-available" by default when channel = dev#104512bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
Author
|
For future work, another thing we could do is change the default profile to |
1f8bd19 to
574cccc
Compare
This comment has been minimized.
This comment has been minimized.
…ev"` See rust-lang/compiler-team#566. The motivation for changing the default is to avoid downloading and building LLVM when someone runs `x build` before running `x setup`. The motivation for only doing it on `channel = "dev"` is to avoid breaking distros or users installing from source. It works because `dev` is also the default channel. The diff looks larger than it is; most of it is moving the `llvm` branch below the `rust` so `config.channel` is set.
574cccc to
ac67262
Compare
Member
|
@bors r+ |
Collaborator
Collaborator
|
⌛ Testing commit ac67262 with merge 4a913d5df06ed53fb3d32fcc1c42fe00acbcfc6a... |
Collaborator
|
💔 Test failed - checks-actions |
Member
Author
Unrelated to this PR, looks like https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Authentication.20failed.20on.20merge.20attempt @bors retry |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#98391 (Reimplement std's thread parker on top of events on SGX) - rust-lang#104019 (Compute generator sizes with `-Zprint_type_sizes`) - rust-lang#104512 (Set `download-ci-llvm = "if-available"` by default when `channel = dev`) - rust-lang#104901 (Implement masking in FileType comparison on Unix) - rust-lang#105082 (Fix Async Generator ABI) - rust-lang#105109 (Add LLVM KCFI support to the Rust compiler) - rust-lang#105505 (Don't warn about unused parens when they are used by yeet expr) - rust-lang#105514 (Introduce `Span::is_visible`) - rust-lang#105516 (Update cargo) - rust-lang#105522 (Remove wrong note for short circuiting operators) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-lang/compiler-team#566. The motivation for changing the default is to avoid downloading and building LLVM when someone runs
x buildbefore runningx setup. The motivation for only doing it onchannel = "dev"is to avoid breaking distros or users installing from source. It works becausedevis also the default channel.The diff looks larger than it is; most of it is moving the
llvmbranch below therustsoconfig.channelis set.r? @Mark-Simulacrum cc @oli-obk @bjorn3 @cuviper