Skip to content

Don't use periods in target names#104523

Merged
bors merged 2 commits intorust-lang:masterfrom
flba-eb:fix_nto_target_name
Nov 30, 2022
Merged

Don't use periods in target names#104523
bors merged 2 commits intorust-lang:masterfrom
flba-eb:fix_nto_target_name

Conversation

@flba-eb
Copy link
Contributor

@flba-eb flba-eb commented Nov 17, 2022 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 17, 2022
@flba-eb
Encourage developers not to use periods in target names
5dd073e 
They can cause issues in e.g. cargo.
@flba-eb flba-eb force-pushed the fix_nto_target_name branch from 99a4701 to 5dd073e Compare November 17, 2022 09:42
@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Nov 17, 2022
@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 17, 2022 •
edited
Loading

CC @ehuss

@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 17, 2022 •
edited
Loading

CI output (excerpt) of 5dd073e, before fixing the issue:

platform support check
   Compiling tier-check v0.1.0 (/checkout/src/tools/tier-check)
    Finished release [optimized] target(s) in 1.04s
     Running `obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/tier-check /checkout/src/doc/rustc/src/platform-support.md /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/rustc`
error: Target name `aarch64-unknown-nto-qnx7.1.0` contains other characters than ASCII alphanumeric (a-z, A-Z, 0-9), dash (-) or underscore (_).
error: Target name `x86_64-pc-nto-qnx7.1.0` contains other characters than ASCII alphanumeric (a-z, A-Z, 0-9), dash (-) or underscore (_).

@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 17, 2022

CC @gh-tr

@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 17, 2022

@wesleywiser and @ehuss , I think this PR is ready for review from your side (especially the test and change/addition in tier 3 policy).
I want to keep it as draft-PR until @gh-tr had the chance to have a look at the QNX/nto related changes as well.

wesleywiser
wesleywiser approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thanks!

@flba-eb flba-eb changed the title WIP: Don't use periods in target names Don't use periods in target names Nov 24, 2022
@flba-eb flba-eb marked this pull request as ready for review November 24, 2022 13:51
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2022

These commits modify compiler targets.
(See the Target Tier Policy.)

@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 24, 2022 •
edited
Loading

Issue was discussed with @gh-tr and the QNX/Neutrino parts have been approved by him.

@gh-tr
Copy link

gh-tr commented Nov 24, 2022

Confirming. Change makes sense.

@wesleywiser
Copy link
Member

wesleywiser commented Nov 28, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 28, 2022

📌 Commit 9c3555d has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#104523 - flba-eb:fix_nto_target_name, r=wes…
7baba03 
…leywiser

Don't use periods in target names

Using a period in the target name can cause issues in e.g. cargo, see also https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Running.20tests.20on.20remote.20target
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2022
@bors
Auto merge of rust-lang#105070 - matthiaskrgr:rollup-9b25khj, r=matth…
d38a990 
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds)
 - rust-lang#104427 (Explain why `rematch_impl` fails to be infallible)
 - rust-lang#104436 (Add slice to the stack allocated string comment)
 - rust-lang#104523 (Don't use periods in target names)
 - rust-lang#104627 (Print all features with --print target-features)
 - rust-lang#104911 (Make inferred_outlives_crate return Clause)
 - rust-lang#105002 (Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str`)
 - rust-lang#105023 (Statics used in reachable function's inline asm are reachable)
 - rust-lang#105045 (`rustc_ast_{passes,pretty}`: remove `ref` patterns)
 - rust-lang#105049 (Hermit: Minor build fixes)
 - rust-lang#105051 (Replace a macro with a function)
 - rust-lang#105062 (rustdoc: use shorthand background for rustdoc toggle CSS)
 - rust-lang#105066 (move `candidate_from_obligation` out of assembly)
 - rust-lang#105068 (Run patchelf also on rust-analyzer-proc-macro-srv.)

Failed merges:

 - rust-lang#105050 (Remove useless borrows and derefs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3e9a223 into rust-lang:master Nov 30, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 30, 2022
flba-eb added a commit to flba-eb/ctest2 that referenced this pull request Dec 6, 2022
@flba-eb
Adapt to changed target names
b509410 
See rust-lang/rust#104523
flba-eb added a commit to flba-eb/ctest2 that referenced this pull request Dec 6, 2022
@flba-eb
fix: don't use periods in target names
7b3154c 
See rust-lang/rust#104523
@flba-eb flba-eb mentioned this pull request Dec 6, 2022
Merged
@workingjubilee workingjubilee added the O-neutrino OS: QNX Neutrino, a POSIX-compatible real-time operating system label Feb 27, 2023
tgross35 pushed a commit to tgross35/ctest2 that referenced this pull request Apr 2, 2025
@flba-eb
fix: don't use periods in target names
f0463a7 
See rust-lang/rust#104523
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 2, 2025
@flba-eb @tgross35
fix: don't use periods in target names
cf4451d 
See rust-lang/rust#104523
tgross35 pushed a commit to tgross35/ctest2 that referenced this pull request Apr 2, 2025
@flba-eb
fix: don't use periods in target names
1bc65df 
See rust-lang/rust#104523
sanstzu pushed a commit to sanstzu/rust-libc that referenced this pull request May 16, 2025
@flba-eb @sanstzu
fix: don't use periods in target names
2cf2390 
See rust-lang/rust#104523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc O-neutrino OS: QNX Neutrino, a POSIX-compatible real-time operating system S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

6 participants

@flba-eb @rustbot @gh-tr @wesleywiser @bors @workingjubilee