Merged
Conversation
Signed-off-by: ozkanonur <work@onurozkan.dev>
Signed-off-by: ozkanonur <work@onurozkan.dev>
…se-sugg, r=lcnr Fix hang in where-clause suggestion with `predicate_can_apply` Using `predicate_may_hold` during error reporting causes an evaluation overflow, which (because we use `evaluate_obligation_no_overflow`) then causes the predicate to need to be re-evaluated locally, which results in a hang. ... but since the "add a where clause" suggestion is best-effort, just throw any overflow errors. No need for 100% accuracy. r? `@lcnr` who has been thinking about overflows... Let me know if you want more context about this issue, and as always, feel free to reassign. Fixes rust-lang#104225
…ilation, r=jyn514 copy doc output files by format This pr provides copying doc outputs by checking output format without removing output directory on each trigger. Resolves rust-lang#103785
…lcnr Use obligation ctxt instead of dyn TraitEngine r? `@lcnr`
Remove more `ref` patterns from the compiler r? `@oli-obk` Previous PR: rust-lang#104500
…display-block, r=GuillaumeGomez rustdoc: give struct fields CSS `display: block` Fixes rust-lang#104737
…nkov Fix an ICE parsing a malformed attribute. Fixes rust-lang#104620. r? `@petrochenkov`
rustbot
added
T-bootstrap
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 80b3c6dbde In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 23, 2022
Collaborator
|
Finished benchmarking commit (d121aa3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
predicate_can_apply#104269 (Fix hang in where-clause suggestion withpredicate_can_apply)refpatterns from the compiler #104721 (Remove morerefpatterns from the compiler)display: block#104744 (rustdoc: give struct fields CSSdisplay: block)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup