Merged
Conversation
It's misleading unless it gets changed to respond to being clicked.
text #fff on background #fdffd3 fails the [WCAG color contrast checker], and seems like a mistake in 16b5590. [WCAG color contrast checker]: https://accessibleweb.com/color-contrast-checker/
move 2 candidates into builtin candidate having separate candidates for these isn't too helpful i think r? types
…rochenkov Clarify `SyntaxExtensionKind::LegacyDerive`. It's always treated the same as `SyntaxExtensionKind::Derive`.
…h726 rustc_codegen_ssa: write `.dwp` in a streaming fashion When writing a `.dwp` file, rustc writes to a Vec first then to a BufWriter-wrapped file. It seems very likely that we can write in a streaming fashion to avoid double buffering in an intermediate Vec. On my Linux machine, `.dwp` from the latest rust-lang/cargo is 113MiB. It may worth a stream writer, though I didn't do any benchmark 🙇🏾♂️.
…_associated_types_in, r=lcnr Use infcx.partially_normalize_associated_types_in r? ``@lcnr``
Fix typo in miri sysroot r? ``@RalfJung``
… r=GuillaumeGomez jsondoclint: Recognise Typedef as valid kind for Type::ResolvedPath Closes rust-lang#104851 r? ``@GuillaumeGomez`` ``@rustbot`` modify labels: +A-testsuite
…hared-assets, r=jyn514
rustbuild: Don't build doc::SharedAssets when building JSON docs.
Previously, running `./x doc library/core/ --json` on a plain build would panic bootstrap.
```
$ ./x doc library/core/ --json
Building rustbuild
Blocking waiting for file lock on package cache
Compiling bootstrap v0.0.0 (/home/nixon/dev/rust/rust/src/bootstrap)
Finished dev [unoptimized] target(s) in 4.47s
thread 'main' panicked at 'fs::write(&version_info, &info) failed with No such file or directory (os error 2) ("/home/nixon/dev/rust/rust/build/x86_64-unknown-linux-gnu/doc/version_info.html")', doc.rs:410:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:00:04
```
Becuase the `SharedAssets` step assumes that the HTML out dir has been created. This isn't true for JSON.
The fix is to not build shared assets when doing a JSON doc build, as it doesn't need them.
r? ``@jyn514``
``@rustbot`` modify labels: +A-rustdoc-json
…llaumeGomez rustdoc: fix broken tooltip CSS text `#ffffff` on background `#fdffd3` fails the [WCAG color contrast checker], and seems like a mistake in rust-lang@16b5590. Making the cursor a pointer is misleading, since clicking it doesn't do anything. [WCAG color contrast checker]: https://accessibleweb.com/color-contrast-checker/
rustbot
added
T-bootstrap
Member
Author
|
@bors r+ rollup=never p=8 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR: previous master: 051cab2b84 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 25, 2022
Collaborator
|
Finished benchmarking commit (8681d4c): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
SyntaxExtensionKind::LegacyDerive. #104760 (ClarifySyntaxExtensionKind::LegacyDerive.).dwpin a streaming fashion #104797 (rustc_codegen_ssa: write.dwpin a streaming fashion)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup