rustdoc: remove redundant CSS .code-wrapper { position: relative }#106279
Closed
notriddle wants to merge 1 commit intorust-lang:masterfrom
Closed
rustdoc: remove redundant CSS .code-wrapper { position: relative }#106279notriddle wants to merge 1 commit intorust-lang:masterfrom
.code-wrapper { position: relative }#106279notriddle wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
Contributor
Author
|
Wait, no. This doesn't work. It isn't the same on small screens 🤦.
|
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 30, 2022
…ples-layout-test, r=notriddle Extend scraped examples layout GUI test for position of buttons This is a regression test for rust-lang#106279. r? `@notriddle`
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 31, 2022
…ples-layout-test, r=notriddle Extend scraped examples layout GUI test for position of buttons This is a regression test for rust-lang#106279. r? ``@notriddle``
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 31, 2022
…ples-layout-test, r=notriddle Extend scraped examples layout GUI test for position of buttons This is a regression test for rust-lang#106279. r? ```@notriddle```
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Dec 31, 2022
…ples-layout-test, r=notriddle Extend scraped examples layout GUI test for position of buttons This is a regression test for rust-lang#106279. r? ````@notriddle````
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line, added in 4b3f82a, was part of how the expand/prev/next buttons were aligned.
Now that 6ccd14a made the outer wrapper has relative position, though, it doesn't matter any more, because those buttons will get the same position when they're made relative to that.