test: snapshot for derive suggestion in diff files

[bvanjoi]

fixed #107649

[rustbot]

r? @nagisa

(rustbot has picked a reviewer for you, use r? to override)

[matthiaskrgr]

Your pr only contains tests i think it's missing the source change?

[bvanjoi]

Your pr only contains tests i think it's missing the source change?

since I found that it turned out as expected when I tried to reproduce the problem in the issue, I just added some test cases.

[matthiaskrgr]

My problem was the " |{path}" which caused "|compiler/rustc_lint/src/lints.rs" to be opened when clicking on it instead of "compiler/rustc_lint/src/lints.rs".

help: consider annotating `UnusedDelimSuggestion` with `#[derive(Debug)]`
   --> |compiler/rustc_lint/src/lints.rs:1465:1
    |

but I don't see this "|{path}" pattern at all in your test output 🤔

[bvanjoi]

My problem was the " |{path}" which caused "|compiler/rustc_lint/src/lints.rs" to be opened when clicking on it instead of "compiler/rustc_lint/src/lints.rs".

help: consider annotating `UnusedDelimSuggestion` with `#[derive(Debug)]`
   --> |compiler/rustc_lint/src/lints.rs:1465:1
    |

but I don't see this "|{path}" pattern at all in your test output 🤔

Then maybe I'm misunderstanding something. Can you post the reproduction steps so I can check and fix it?

[estebank]

help: consider annotating `UnusedDelimSuggestion` with `#[derive(Debug)]`
   --> |compiler/rustc_lint/src/lints.rs:1465:1
    |

should be

help: consider annotating `UnusedDelimSuggestion` with `#[derive(Debug)]`
   --> compiler/rustc_lint/src/lints.rs:1465:1
    |

The leading pipe before the path is a bug somewhere in the diagnostics machinery. It is ok to open a PR adding a test (but it shouldn't close the original ticket until solved).

[bvanjoi]

help: consider annotating `UnusedDelimSuggestion` with `#[derive(Debug)]`
   --> |compiler/rustc_lint/src/lints.rs:1465:1
    |

should be

help: consider annotating `UnusedDelimSuggestion` with `#[derive(Debug)]`
   --> compiler/rustc_lint/src/lints.rs:1465:1
    |

The leading pipe before the path is a bug somewhere in the diagnostics machinery. It is ok to open a PR adding a test (but it shouldn't close the original ticket until solved).

Understood, I have replicated this issue locally and will try to fix it in the near future

[bvanjoi]

Help review it if you have time @matthiaskrgr @estebank

[estebank]

r? @estebank
@bors r+ rollup

[bors]

📌 Commit 7615045 has been approved by estebank

It is now in the queue for this repository.