Fix is_terminal's handling of long paths on Windows.#108391
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 24, 2023
Merged
Fix is_terminal's handling of long paths on Windows.#108391bors merged 1 commit intorust-lang:masterfrom
is_terminal's handling of long paths on Windows.#108391bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @ChrisDenton (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Collaborator
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This comment has been minimized.
This comment has been minimized.
ChrisDenton
approved these changes
Feb 23, 2023
Member
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
This looks good to me. I only have a very minor doc comment nit. Also if you could squish the commits into one then I'll ask bors to merge.
sunfishcode
force-pushed
the
sunfishcode/is-terminal-file-length
branch
from
a7a395a to
46eddd4
Compare
Member
Author
|
I've now sqashed the commits into one. |
As reported in sunfishcode/is-terminal#18, there are situations where `GetFileInformationByHandleEx` can write a file name length that is longer than the provided buffer. To avoid deferencing memory past the end of the buffer, use a bounds-checked function to form a slice to the buffer and handle the out-of-bounds case. This ports the fix from sunfishcode/is-terminal#19 to std's `is_terminal` implementation.
sunfishcode
force-pushed
the
sunfishcode/is-terminal-file-length
branch
from
46eddd4 to
c0c1925
Compare
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Feb 23, 2023
chore: bump is-terminal to 0.4.4 Fixes #11710. See sunfishcode/is-terminal#18 See also rust-lang/rust#108391
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 23, 2023
…l-file-length, r=ChrisDenton Fix `is_terminal`'s handling of long paths on Windows. As reported in sunfishcode/is-terminal#18, there are situations where `GetFileInformationByHandleEx` can write a file name length that is longer than the provided buffer. To avoid deferencing memory past the end of the buffer, use a bounds-checked function to form a slice to the buffer and handle the out-of-bounds case. This ports the fix from sunfishcode/is-terminal#19 to std's `is_terminal` implementation.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2023
Rollup of 10 pull requests Successful merges: - rust-lang#106541 (implement const iterator using `rustc_do_not_const_check`) - rust-lang#106918 (Rebuild BinaryHeap on unwind from retain) - rust-lang#106923 (Restore behavior when primary bundle is missing) - rust-lang#108169 (Make query keys `Copy`) - rust-lang#108287 (Add test for bad cast with deferred projection equality) - rust-lang#108370 (std: time: Avoid to use "was created" in elapsed() description) - rust-lang#108377 (Fix ICE in 'duplicate diagnostic item' diagnostic) - rust-lang#108388 (parser: provide better suggestions and errors on closures with braces missing) - rust-lang#108391 (Fix `is_terminal`'s handling of long paths on Windows.) - rust-lang#108401 (diagnostics: remove inconsistent English article "this" from E0107) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in sunfishcode/is-terminal#18, there are situations where
GetFileInformationByHandleExcan write a file name length that is longer than the provided buffer. To avoid deferencing memory past the end of the buffer, use a bounds-checked function to form a slice to the buffer and handle the out-of-bounds case.This ports the fix from sunfishcode/is-terminal#19 to std's
is_terminalimplementation.