[107049][Easy] Modify readme to suggest using configure#108641
[107049][Easy] Modify readme to suggest using configure#108641lionellloh wants to merge 3 commits intorust-lang:masterfrom
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
|
I think this should be changed to suggest using |
Ooh do you mind explaining why so? I am new so just passing the message from #107049 from @jyn514
|
|
@albertlarsan68 they are not quite the same. |
|
@bors r+ rollup |
|
@bors r- |
|
Then I think there should be a section for the distros, and one for the users wanting to build from source. |
Remove accidentally inserted line Co-authored-by: jyn <github@jyn.dev>
|
I don't really want to add more blessed paths 😓 bootstrap has enough configuration knobs as-is. What are you hoping to gain from having people run |
jyn514
left a comment
There was a problem hiding this comment.
Wait, so I read the original issue and this doesn't actually do what I want - I want ./configure to set profile=user by default, even if --set profile isn't passed.
|
In one of the guides, it is recommended that x is used rather than configure, since the makefile it produces is just a wrapper around x. |
Co-authored-by: jyn <github@jyn.dev>
|
I think I have applied the change requested @jyn514 |
@lionellloh I don't see this change. |
Do you have a link to this? I vaguely remember some text saying "configure generates config.toml", but not a recommendation against using it. |
|
Hi @lionellloh, it's been a while - do you know when you'll have time to look at this again? Is it clear what to do? |
|
Going to close this in favor of #110541. |
Fix various configure bugs Fixes rust-lang#107050. Fixes rust-lang#108928. Closes rust-lang#108641. I recommend reading this commit-by-commit to see the commit descriptions, but the code changes are small. This also changes the README to suggest `configure` instead of `printf`, as well as a few other cleanups described in the commit message.
This is related to #107050. Modifying instructions in readme to use configure instead of printf
Manual Test:
Command
Result