'./configure' now checks if 'config.toml' exists before writing to that destination

[madsravn]

Fixes #110109

Instead of overwriting the current config.toml file, exit the ./configure script with a message stating why.

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[KittyBorgX]

Can the function definition can be ommited and if os.path.isfile() block be directly placed in if __name__ == "__main__"?
Since there are no other function calls of the quit_if_file_exists function and its being abstracted away unnessecerily.

[madsravn]

Can the function definition can be ommited and if os.path.isfile() block be directly placed in if __name__ == "__main__"? Since there are no other function calls of the quit_if_file_exists function and its being abstracted away unnessecerily.

Thank you for your suggestion. If it isn't against any of the style guidelines, I would like to keep it in its own function. A function has a name which goes to show intent. Also I would like to clutter as little as possible in the main function as possible.

[KittyBorgX]

A function has a name which goes to show intent.

A comment could perhaps do the same? Though I'm unsure of it. With regard to the style guide, I believe there are no rules against abstracting away to a function but I suggested doing against that since we're dealing with python and it could increase time usage and size of the file merely 😅

I'd suggest changing the quit() however as I mentioned in a former review. With regard to the abstraction of function, I think it's best to wait for Mark (the reviewer for this PR) to reply since that would provide a greater clarity.

[jyn514]

This seems good :) r=me with the two comments addressed.

[jyn514]

Thanks!

@bors r+ rollup

[bors]

📌 Commit 010d797 has been approved by jyn514

It is now in the queue for this repository.

[xiangzhai]

Or just rename it as config.toml.bak?

diff --git a/src/bootstrap/configure.py b/src/bootstrap/configure.py
index f95a97518c5..eaa4c71b4a3 100755
--- a/src/bootstrap/configure.py
+++ b/src/bootstrap/configure.py
@@ -525,7 +525,8 @@ def write_config_toml(writer, section_order, targets, sections):
 
 def quit_if_file_exists(file):
     if os.path.isfile(file):
-        err("Existing '" + file + "' detected.")
+        os.rename(file, file + ".bak")
+        print("Existing '" + file + "' detected.")
 
 if __name__ == "__main__":
     # If 'config.toml' already exists, exit the script at this point

./src/ci/docker/run.sh dist-your-image will exit:

sccache: Starting the server...
configure: error: Existing 'config.toml' detected.

Thanks,
Leslie Zhai