Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
jsoref
left a comment
There was a problem hiding this comment.
I'll squash if the changes are ok
src/etc/lldb_lookup.py
Outdated
There was a problem hiding this comment.
This is the only interesting part of this change. I'm assuming that uppercase doesn't imply a frozen/public symbol.
|
Please squash commits, r=me after that. |
spelling: exactly spelling: synthetic Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
0f0c0b7 to
50240b3
Compare
|
@Mark-Simulacrum squashed |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (77778e0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
The various src/* items seem slightly disparate, so I'm doing src/* individually.
split from #110392