Use llvm-config instead of download-ci-llvm in PGO script#113323
Use llvm-config instead of download-ci-llvm in PGO script#113323bors merged 2 commits intorust-lang:masterfrom
llvm-config instead of download-ci-llvm in PGO script#113323Conversation
This should avoid CI breakage when the LLVM stamp is updated, and also it will avoid an unnecessary LLVM download from CI.
|
@bors r+ |
|
I'll also start a try build, we should see in ~hour if it works, to avoid an unnecessarily failed merge. @bors try |
|
🙅 Please do not |
|
Ok, apparently I will not. |
This comment has been minimized.
This comment has been minimized.
|
@bors rollup=iffy |
For context, bors has a funny bug where it insta pushes a PR to master if you r+ during a try build. Oh nevermind, this is older than knowledge of the bug, this appears to be a normal message. Interesting. |
|
⌛ Testing commit be99bb9 with merge 3561b7a159440a6c68521b4f328c88750bc69945... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
@rustbot ready I realized that by default the tests won't run in a try build, so we might as well just retry the merge. |
|
@bors r=jyn514 |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c4c84df): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 656.625s -> 657.995s (0.21%) |
This should avoid CI breakage when the LLVM stamp is updated, and also it will avoid an unnecessary LLVM download from CI.
r? @jyn514