Use `upvar_tys` in more places, make it return a list#114079

compiler-errors · 2023-07-26T01:14:23Z

Just a cleanup that fell out of a PR that I was gonna write, but that PR kinda got stuck.

rustbot · 2023-07-26T01:14:28Z

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-07-26T01:14:31Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

compiler-errors · 2023-07-26T01:14:39Z

probably shouldnt matter, but let's see

@bors try @rust-timer queue

bors · 2023-07-26T01:14:47Z

⌛ Trying commit 59571266f44c3b285770aa0018d0da88679fd937 with merge 5eb97f48bed6d5a9258294931ebb9b872c8d2ba9...

bors · 2023-07-26T02:32:03Z

☀️ Try build successful - checks-actions
Build commit: 5eb97f48bed6d5a9258294931ebb9b872c8d2ba9 (5eb97f48bed6d5a9258294931ebb9b872c8d2ba9)

compiler/rustc_middle/src/ty/layout.rs

compiler/rustc_mir_dataflow/src/elaborate_drops.rs

compiler/rustc_mir_transform/src/generator.rs

compiler/rustc_trait_selection/src/traits/query/dropck_outlives.rs

rust-timer · 2023-07-26T23:41:14Z

Finished benchmarking commit (5eb97f48bed6d5a9258294931ebb9b872c8d2ba9): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.0%	[-4.0%, -4.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.0%	[-4.0%, -4.0%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.399s -> 651.262s (0.13%)

oli-obk · 2023-08-02T07:49:55Z

@bors r+ rollup

bors · 2023-08-02T07:49:56Z

📌 Commit 99969d2 has been approved by oli-obk

It is now in the queue for this repository.

…oli-obk Use `upvar_tys` in more places, make it return a list Just a cleanup that fell out of a PR that I was gonna write, but that PR kinda got stuck.

Rollup of 5 pull requests Successful merges: - rust-lang#114079 (Use `upvar_tys` in more places, make it return a list) - rust-lang#114166 (Add regression test for resolving `--extern libc=test.rlib`) - rust-lang#114321 (get auto traits for parallel rustc) - rust-lang#114335 (fix and extend ptr_comparison test) - rust-lang#114347 (x.py print more detailed format files and untracked files count) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned b-naber Jul 26, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 26, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 26, 2023

compiler-errors added C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 26, 2023

This comment has been minimized.

Sign in to view