Skip to content

effects: Run enforce_context_effects for all method calls#118282

Merged
bors merged 2 commits intorust-lang:masterfrom
fee1-dead-contrib:enforce-more
Nov 28, 2023
Merged

effects: Run enforce_context_effects for all method calls#118282
bors merged 2 commits intorust-lang:masterfrom
fee1-dead-contrib:enforce-more

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Nov 25, 2023

So that we also perform checks when overloaded PartialEqs are called.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2023

Some changes might have occurred in exhaustiveness checking

cc @Nadrieril

compiler-errors
compiler-errors approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments just to make sure I have the right understanding...

tests/ui/rfcs/rfc-2632-const-trait-impl/effects/minicore.rs

#[lang = "eq"]
#[const_trait]
// FIXME #[const_trait]
Copy link
Contributor

@compiler-errors compiler-errors Nov 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What breaks here, out of curiosity? from_str should be host = true, so why can't we evaluate the PartialEq obligation in the match above?

Copy link
Member Author

@fee1-dead fee1-dead Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only explanation here for this breaking is that we begun checking == method calls. Having this led to ICEs about mismatched number of generic arguments for PartialEq.

@compiler-errors
Copy link
Contributor

compiler-errors commented Nov 27, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 27, 2023

📌 Commit dd3437b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2023
@matthiaskrgr
Rollup merge of rust-lang#118282 - fee1-dead-contrib:enforce-more, r=…
f01a3aa 
…compiler-errors

effects: Run `enforce_context_effects` for all method calls

So that we also perform checks when overloaded `PartialEq`s are called.

r? `@compiler-errors`
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 27, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2023
@bors
Auto merge of rust-lang#118380 - matthiaskrgr:rollup-cfekmpm, r=matth…
c37783d 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#111133 (Detect Python-like slicing and suggest how to fix)
 - rust-lang#114708 (Allow setting `rla` labels via `rustbot`)
 - rust-lang#117526 (Account for `!` arm in tail `match` expr)
 - rust-lang#118282 (effects: Run `enforce_context_effects` for all method calls)
 - rust-lang#118366 (Detect and reject malformed `repr(Rust)` hints)
 - rust-lang#118375 (Add -Zunpretty=stable-mir output test)

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors compiler-errors mentioned this pull request Nov 28, 2023
Merged
@bors
Copy link
Collaborator

bors commented Nov 28, 2023

⌛ Testing commit dd3437b with merge e06c94d...

@bors
Copy link
Collaborator

bors commented Nov 28, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e06c94d to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Nov 28, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e06c94d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 28, 2023
@bors bors merged commit e06c94d into rust-lang:master Nov 28, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 28, 2023
@bors bors mentioned this pull request Nov 28, 2023
Closed
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 28, 2023

Finished benchmarking commit (e06c94d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)		 -2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.8% [-2.8%, -2.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.319s -> 673.509s (-0.12%)
Artifact size: 313.36 MiB -> 313.37 MiB (0.00%)

@fee1-dead fee1-dead deleted the enforce-more branch December 1, 2023 16:37
@fee1-dead fee1-dead mentioned this pull request Dec 6, 2023
Closed
4 tasks
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 15, 2024
Closed
@fmease fmease added PG-const-traits Project group: Const traits F-effects `#![feature(effects)]` labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

F-effects `#![feature(effects)]` merged-by-bors This PR was explicitly merged by bors. PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

6 participants

@fee1-dead @rustbot @compiler-errors @bors @rust-timer @fmease