fix: correct the arg for 'suggest to use associated function syntax' diagnostic#118502
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 9, 2023
Merged
fix: correct the arg for 'suggest to use associated function syntax' diagnostic#118502bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Member
Author
Collaborator
Collaborator
Member
Author
|
could @saethlin help review this? |
Member
|
Did you pick me because you saw my name on the issue? I really don't know much of anything about this part of the compiler, so I wouldn't have picked me. |
Member
Author
Oh yeah.
Sorry for the interruption. |
Member
|
No need to apologize. A lot of the compiler team tends to go on vacation around this time, and some of the contributors group (which I'm in) does get review requests. r? compiler |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#117586 (Uplift the (new solver) canonicalizer into `rustc_next_trait_solver`) - rust-lang#118502 (fix: correct the arg for 'suggest to use associated function syntax' diagnostic) - rust-lang#118694 (Add instance evaluation and methods to read an allocation in StableMIR) - rust-lang#118715 (privacy: visit trait def id of projections) - rust-lang#118730 (recurse into refs when comparing tys for diagnostics) - rust-lang#118736 (temporarily revert "ice on ambguity in mir typeck") r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
Rollup merge of rust-lang#118502 - Young-Flash:fix, r=compiler-errors fix: correct the arg for 'suggest to use associated function syntax' diagnostic close rust-lang#118469
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 9, 2023
chore: add test case for type with generic follow up rust-lang#118502
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2023
Rollup merge of rust-lang#118775 - Young-Flash:fix, r=compiler-errors chore: add test case for type with generic follow up rust-lang#118502
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2023
fix: correct the args for `disambiguate the associated function` diagnostic This is somehow silimar to rust-lang#118502, we shouldn't take receiver as first arg all the cases. close rust-lang#118819
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 31, 2023
fix: correct the args for `disambiguate the associated function` diagnostic This is somehow silimar to rust-lang/rust#118502, we shouldn't take receiver as first arg all the cases. close rust-lang/rust#118819
This was referenced Jan 9, 2024
Nadrieril
added a commit
to Nadrieril/rust
that referenced
this pull request
Jan 27, 2024
fix: correct suggestion arg for impl trait follow up rust-lang#118502, close rust-lang#119775
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 27, 2024
fix: correct suggestion arg for impl trait follow up rust-lang#118502, close rust-lang#119775
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2024
Rollup merge of rust-lang#119957 - Young-Flash:fix, r=fmease fix: correct suggestion arg for impl trait follow up rust-lang#118502, close rust-lang#119775
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
fix: correct the args for `disambiguate the associated function` diagnostic This is somehow silimar to rust-lang/rust#118502, we shouldn't take receiver as first arg all the cases. close rust-lang/rust#118819
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
fix: correct the args for `disambiguate the associated function` diagnostic This is somehow silimar to rust-lang/rust#118502, we shouldn't take receiver as first arg all the cases. close rust-lang/rust#118819
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #118469