Strengthen well known check-cfg names and values test#118702

Urgau · 2023-12-07T11:42:03Z

#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them.

This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry.

this PR also contains some drive-by consolidation of unexpected target_os, target_arch into a single file

r? @nnethercote (maybe? feel free to re-assign)

compiler/rustc_session/src/config.rs

tests/ui/check-cfg/well-known-values.rs

nnethercote · 2023-12-07T23:13:30Z

this PR also contains some drive-by consolidation of unexpected target_os, target_arch into a single file

I generally put these kinds of changes into separate commits. It makes the reviewer's job easier when unrelated changes are separated out.

This is desired for rust-lang#118702.

tests/ui/check-cfg/well-known-values.rs

bors · 2023-12-08T11:09:20Z

✌️ @Urgau, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, please make that change, then do @bors r=@nnethercote

Urgau · 2023-12-08T12:44:29Z

@bors r=@nnethercote rollup=always

bors · 2023-12-08T12:44:31Z

@Urgau: 🔑 Insufficient privileges: Not in reviewers

bors · 2023-12-08T12:44:32Z

@Urgau: 🔑 Insufficient privileges: not in try users

Urgau · 2023-12-08T12:50:08Z

@bors r=nnethercote

bors · 2023-12-08T12:50:11Z

@Urgau: 🔑 Insufficient privileges: Not in reviewers

GuillaumeGomez · 2023-12-08T12:50:38Z

Weird. Oh well.

@bors r=nnethercote rollup

bors · 2023-12-08T12:50:41Z

📌 Commit 5a17ee7 has been approved by nnethercote

It is now in the queue for this repository.

…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? `@nnethercote` (maybe? feel free to re-assign)

…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? ``@nnethercote`` (maybe? feel free to re-assign)

…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ``@Nilstrieb``

…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? ```@nnethercote``` (maybe? feel free to re-assign)

…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ```@Nilstrieb```

GuillaumeGomez · 2023-12-08T14:30:25Z

Failed in #118744.

…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ````@Nilstrieb````

…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? `@nnethercote` (maybe? feel free to re-assign)

…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? `@Nilstrieb`

workingjubilee · 2023-12-09T05:35:20Z

@bors r-

…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ``@Nilstrieb``

…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ```@Nilstrieb```

as they unnecessarily clutter the diagnostic output and make the experience of adding a new target to the compiler more painful than it should be. target_os and target_arch are still being tested in the well-known-values.rs test, but in one place.

Rollup merge of rust-lang#118737 - nnethercote:tidy-alphabetical-in-testsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ```@Nilstrieb```

Urgau · 2023-12-09T12:48:06Z

I've rebased and re-blessed the diagnostic output (new win7 target).

@rustbot ready

GuillaumeGomez · 2023-12-09T13:04:40Z

@bors r=nnethercote

bors · 2023-12-09T13:04:42Z

📌 Commit 4c16716 has been approved by nnethercote

It is now in the queue for this repository.

…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#117953 (Add more SIMD platform-intrinsics) - rust-lang#118057 (dedup for duplicate suggestions) - rust-lang#118638 (More `rustc_mir_dataflow` cleanups) - rust-lang#118702 (Strengthen well known check-cfg names and values test) - rust-lang#118734 (Unescaping cleanups) - rust-lang#118766 (Lower some forgotten spans) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118702 - Urgau:check-cfg-strengthen-well-known, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? `@nnethercote` (maybe? feel free to re-assign)

rustbot assigned nnethercote Dec 7, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 7, 2023

nnethercote reviewed Dec 7, 2023

View reviewed changes

compiler/rustc_session/src/config.rs Show resolved Hide resolved

tests/ui/check-cfg/well-known-values.rs Outdated Show resolved Hide resolved

tests/ui/check-cfg/well-known-values.rs Outdated Show resolved Hide resolved

tests/ui/check-cfg/well-known-values.rs Show resolved Hide resolved

Urgau force-pushed the check-cfg-strengthen-well-known branch from 5bfb9f5 to 455d583 Compare December 8, 2023 00:16

nnethercote added a commit to nnethercote/rust that referenced this pull request Dec 8, 2023

Extend tidy alphabetical checking to tests/.

5d16c54

This is desired for rust-lang#118702.

nnethercote mentioned this pull request Dec 8, 2023

Extend tidy alphabetical checking to tests/. #118737

Merged

Urgau force-pushed the check-cfg-strengthen-well-known branch from 455d583 to 28524b3 Compare December 8, 2023 10:53

nnethercote reviewed Dec 8, 2023

View reviewed changes

tests/ui/check-cfg/well-known-values.rs Outdated Show resolved Hide resolved

Urgau force-pushed the check-cfg-strengthen-well-known branch from 28524b3 to 5a17ee7 Compare December 8, 2023 11:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2023

GuillaumeGomez mentioned this pull request Dec 8, 2023

Rollup of 7 pull requests #118740

Closed

GuillaumeGomez mentioned this pull request Dec 8, 2023

Rollup of 7 pull requests #118743

Closed

GuillaumeGomez mentioned this pull request Dec 8, 2023

Rollup of 6 pull requests #118744

Closed

workingjubilee mentioned this pull request Dec 9, 2023

Rollup of 9 pull requests #118767

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 9, 2023

Urgau added 2 commits December 9, 2023 11:59

Strengthen well known check-cfg names and values test

bba9862

Urgau force-pushed the check-cfg-strengthen-well-known branch from 5a17ee7 to 4c16716 Compare December 9, 2023 11:05

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 9, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2023

GuillaumeGomez mentioned this pull request Dec 9, 2023

Rollup of 6 pull requests #118780

Merged

bors merged commit 78d2c8e into rust-lang:master Dec 9, 2023

rustbot added this to the 1.76.0 milestone Dec 9, 2023

Urgau deleted the check-cfg-strengthen-well-known branch December 9, 2023 17:08

Uh oh!

Conversation

Urgau commented Dec 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nnethercote commented Dec 7, 2023

Uh oh!

Uh oh!

bors commented Dec 8, 2023

Uh oh!

Urgau commented Dec 8, 2023

Uh oh!

bors commented Dec 8, 2023

Uh oh!

bors commented Dec 8, 2023

Uh oh!

Urgau commented Dec 8, 2023

Uh oh!

bors commented Dec 8, 2023

Uh oh!

GuillaumeGomez commented Dec 8, 2023

Uh oh!

bors commented Dec 8, 2023

Uh oh!

GuillaumeGomez commented Dec 8, 2023

Uh oh!

workingjubilee commented Dec 9, 2023

Uh oh!

Urgau commented Dec 9, 2023

Uh oh!

GuillaumeGomez commented Dec 9, 2023

Uh oh!

bors commented Dec 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants