exclude unexported macro bindings from extern crate#119369

bvanjoi · 2023-12-28T07:38:50Z

Fixes #119301

Macros that aren't exported from an external crate should not be defined.

r? @petrochenkov

compiler/rustc_resolve/src/build_reduced_graph.rs

petrochenkov · 2023-12-28T15:38:33Z

@bors try

bors · 2023-12-28T15:39:43Z

⌛ Trying commit 6b62275 with merge 3832a95...

exclude unexported macro bindings from extern crate Fixes rust-lang#119301 Macros that aren't exported from an external crate should not be defined. r? `@petrochenkov`

bors · 2023-12-28T17:05:20Z

☀️ Try build successful - checks-actions
Build commit: 3832a95 (3832a95f57d4260fb5641e183906f49b4e5c6bdd)

bors · 2023-12-28T17:05:20Z

☀️ Try build successful - checks-actions
Build commit: 3832a95 (3832a95f57d4260fb5641e183906f49b4e5c6bdd)

petrochenkov · 2023-12-28T17:15:17Z

@craterbot check

craterbot · 2023-12-28T17:15:25Z

👌 Experiment pr-119369 created and queued.
🤖 Automatically detected try build 3832a95
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-12-28T17:15:30Z

🚧 Experiment pr-119369 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-12-30T12:24:27Z

🎉 Experiment pr-119369 is completed!
📊 1281 regressed and 4 fixed (403354 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2023-12-30T16:22:28Z

Many "No space left on device" errors, need to run for the second time as usual.
@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-119369/retry-regressed-list.txt

craterbot · 2023-12-30T16:22:33Z

👌 Experiment pr-119369-1 created and queued.
🤖 Automatically detected try build 3832a95
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-12-30T16:23:35Z

🚧 Experiment pr-119369-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-12-30T16:45:04Z

🎉 Experiment pr-119369-1 is completed!
📊 1198 regressed and 0 fixed (1281 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

bvanjoi · 2024-01-01T17:34:25Z

The majority of issues are caused by the usage of the quote which exported from other crates. For instance, such instances occur in leptos_macro:

#[macro_use]
extern crate proc_macro_error;

use proc_macro::TokenStream;

#[proc_macro]
pub fn view(_a: TokenStream) -> TokenStream {
  quote!{};
  TokenStream::new()
}

and the reduced was:

// extern-1
#[macro_export]
macro_rules! quote {
    () => {}
}

// extern-2
use extern_1::quote;

// code.rs
#[macro_use]
extern crate sera_2;

fn main() {
  quote! {};
}

bvanjoi · 2024-01-01T17:35:10Z

Should we consider adding a lint for this issue?

compiler/rustc_resolve/src/lib.rs

compiler/rustc_resolve/src/imports.rs

compiler/rustc_resolve/src/build_reduced_graph.rs

petrochenkov · 2024-01-18T16:48:39Z

The issue still need to be created - #119369 (comment).
@rustbot author

compiler/rustc_lint_defs/src/builtin.rs

petrochenkov · 2024-01-21T10:49:28Z

r=me with the remaining nits addressed.

petrochenkov · 2024-01-21T21:53:34Z

Thanks!
@bors r+

bors · 2024-01-21T21:53:36Z

📌 Commit 9c3091e has been approved by petrochenkov

It is now in the queue for this repository.

exclude unexported macro bindings from extern crate Fixes rust-lang#119301 Macros that aren't exported from an external crate should not be defined. r? `@petrochenkov`

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#118578 (core: introduce split_at{,_mut}_checked) - rust-lang#119369 (exclude unexported macro bindings from extern crate) - rust-lang#119408 (xous: misc fixes + add network support) - rust-lang#119943 (std::net: bind update for using backlog as `-1` too.) - rust-lang#119948 (Make `unsafe_op_in_unsafe_fn` migrated in edition 2024) - rust-lang#119999 (remote-test: use u64 to represent file size) - rust-lang#120152 (add help message for `exclusive_range_pattern` error) - rust-lang#120213 (Don't actually make bound ty/const for RTN) - rust-lang#120225 (Fix -Zremap-path-scope typo) Failed merges: - rust-lang#119972 (Add `ErrCode`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119369 - bvanjoi:fix-119301, r=petrochenkov exclude unexported macro bindings from extern crate Fixes rust-lang#119301 Macros that aren't exported from an external crate should not be defined. r? ``@petrochenkov``

Related PRs so far: - rust-lang/rust#119869 - rust-lang/rust#120080 - rust-lang/rust#120128 - rust-lang/rust#119369 - rust-lang/rust#116672 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Signed-off-by: Felipe R. Monteiro <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: tautschnig <[email protected]> Co-authored-by: Qinheping Hu <[email protected]> Co-authored-by: Michael Tautschnig <[email protected]> Co-authored-by: Felipe R. Monteiro <[email protected]>

rustbot assigned petrochenkov Dec 28, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2023

petrochenkov reviewed Dec 28, 2023

View reviewed changes

compiler/rustc_resolve/src/build_reduced_graph.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2023

bvanjoi force-pushed the fix-119301 branch from 10d266b to 6b62275 Compare December 28, 2023 15:36

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 28, 2023

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 30, 2023

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2023

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 30, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2024

petrochenkov reviewed Jan 18, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2024

bvanjoi mentioned this pull request Jan 21, 2024

Tracking Issue for private_macro_use lint #120192

Open

3 tasks

bvanjoi force-pushed the fix-119301 branch from a3883c7 to 13c7d0e Compare January 21, 2024 09:56

This comment has been minimized.

Sign in to view

bvanjoi force-pushed the fix-119301 branch from 13c7d0e to 8288e45 Compare January 21, 2024 10:20

petrochenkov reviewed Jan 21, 2024

View reviewed changes

compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved

compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved

compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved

bvanjoi force-pushed the fix-119301 branch from 8288e45 to 8ea40c8 Compare January 21, 2024 11:38

This comment has been minimized.

Sign in to view

exclude unexported macro bindings from extern crate

9c3091e

bvanjoi force-pushed the fix-119301 branch from 8ea40c8 to 9c3091e Compare January 21, 2024 12:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 21, 2024

matthiaskrgr mentioned this pull request Jan 22, 2024

Rollup of 9 pull requests #120231

Closed

This was referenced Jan 22, 2024

Rollup of 10 pull requests #120235

Closed

Rollup of 9 pull requests #120239

Merged

bors merged commit c5984ca into rust-lang:master Jan 22, 2024

rustbot added this to the 1.77.0 milestone Jan 22, 2024

celinval mentioned this pull request Jan 26, 2024

Upgrade Rust toolchain to nightly-2024-01-23 model-checking/kani#2983

Merged

Uh oh!

Conversation

bvanjoi commented Dec 28, 2023

Uh oh!

Uh oh!

petrochenkov commented Dec 28, 2023

Uh oh!

bors commented Dec 28, 2023

Uh oh!

bors commented Dec 28, 2023

Uh oh!

bors commented Dec 28, 2023

Uh oh!

petrochenkov commented Dec 28, 2023

Uh oh!

craterbot commented Dec 28, 2023

Uh oh!

craterbot commented Dec 28, 2023

Uh oh!

craterbot commented Dec 30, 2023

Uh oh!

petrochenkov commented Dec 30, 2023

Uh oh!

craterbot commented Dec 30, 2023

Uh oh!

craterbot commented Dec 30, 2023

Uh oh!

craterbot commented Dec 30, 2023

Uh oh!

bvanjoi commented Jan 1, 2024

Uh oh!

bvanjoi commented Jan 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jan 18, 2024

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jan 21, 2024

Uh oh!

This comment has been minimized.

petrochenkov commented Jan 21, 2024

Uh oh!

bors commented Jan 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants