Skip to content

pattern_analysis: cleanup manual impls#120516

Merged
bors merged 2 commits intorust-lang:masterfrom
Nadrieril:cleanup-impls
Feb 4, 2024
Merged

pattern_analysis: cleanup manual impls#120516
bors merged 2 commits intorust-lang:masterfrom
Nadrieril:cleanup-impls

Conversation

@Nadrieril
Copy link
Member

@Nadrieril Nadrieril commented Jan 31, 2024

#120420 introduced some unneeded manual impls. I remove them here.

r? @Nilstrieb

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 31, 2024
compiler-errors
compiler-errors reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol these are only Deriveable bc RustMatchCheckCtxt derives Debug. Do we implicitly want to require implementors of TypeCx (that trait has a really strange name, btw, lol) to have to derive Debug 🤔 ?

@Nadrieril
Copy link
Member Author

Nadrieril commented Jan 31, 2024

It made sense to me, in case there's relevant info we want to see in traces... I admit it's fishy

@compiler-errors
Copy link
Contributor

compiler-errors commented Jan 31, 2024

Well there's exactly 0 relevant info being printed currently 😆.

If you want to take advantage of this, could you make sure Debug is a supertrait bound on TypeCx? It moves the errors that users get from the derived bounds a bit earlier in the usage of the library.

@compiler-errors
Copy link
Contributor

compiler-errors commented Jan 31, 2024

oh lol it is

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 31, 2024

📌 Commit 40402cb has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2024
@Nadrieril
Copy link
Member Author

Nadrieril commented Jan 31, 2024

Yeah, it's been a supertrait from the start, unsure why I added it in the first place but 🤷

@Nadrieril
Copy link
Member Author

Nadrieril commented Jan 31, 2024

@bors rollup

@compiler-errors
Copy link
Contributor

compiler-errors commented Jan 31, 2024

I assume it was there because of some derive bounds lol

@Nadrieril
Copy link
Member Author

Nadrieril commented Jan 31, 2024

Lol probably, I think I even added Clone at some point for that x)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#120516 - Nadrieril:cleanup-impls, r=compile…
c4da12a 
…r-errors

pattern_analysis: cleanup manual impls

rust-lang#120420 introduced some unneeded manual impls. I remove them here.

r? `@Nilstrieb`
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 31, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#120516 - Nadrieril:cleanup-impls, r=compile…
5f73290 
…r-errors

pattern_analysis: cleanup manual impls

rust-lang#120420 introduced some unneeded manual impls. I remove them here.

r? ``@Nilstrieb``
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 31, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 1, 2024
@bors
Auto merge of rust-lang#120536 - matthiaskrgr:rollup-wllj7tb, r=matth…
11d66cb 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type)
 - rust-lang#120516 (pattern_analysis: cleanup manual impls)
 - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.)
 - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case)
 - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8)
 - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18)
 - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety)
 - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect)
 - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2024
@bors
Auto merge of rust-lang#120536 - matthiaskrgr:rollup-wllj7tb, r=matth…
5bc7414 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type)
 - rust-lang#120516 (pattern_analysis: cleanup manual impls)
 - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.)
 - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case)
 - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8)
 - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18)
 - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety)
 - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect)
 - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2024
@bors
Auto merge of rust-lang#120536 - matthiaskrgr:rollup-wllj7tb, r=matth…
5976d95 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type)
 - rust-lang#120516 (pattern_analysis: cleanup manual impls)
 - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.)
 - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case)
 - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8)
 - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18)
 - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety)
 - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect)
 - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2024
@bors
Auto merge of rust-lang#120624 - matthiaskrgr:rollup-3gvcl20, r=matth…
268dbbb 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type)
 - rust-lang#120516 (pattern_analysis: cleanup manual impls)
 - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.)
 - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case)
 - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8)
 - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18)
 - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect)
 - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f3ebf1e into rust-lang:master Feb 4, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 4, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2024
@rust-timer
Unrolled build for rust-lang#120516
7e49221 
Rollup merge of rust-lang#120516 - Nadrieril:cleanup-impls, r=compiler-errors

pattern_analysis: cleanup manual impls

rust-lang#120420 introduced some unneeded manual impls. I remove them here.

r? ```@Nilstrieb```
@Nadrieril Nadrieril deleted the cleanup-impls branch February 4, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.78.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Nadrieril @compiler-errors @bors @rustbot @Noratrieb