Record certainty of evaluate_added_goals_and_make_canonical_response call in candidate#124444
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 28, 2024
Merged
Record certainty of evaluate_added_goals_and_make_canonical_response call in candidate#124444bors merged 1 commit intorust-lang:masterfrom
evaluate_added_goals_and_make_canonical_response call in candidate#124444bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lcnr
reviewed
Apr 27, 2024
Contributor
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
some naming nits,while I personally prefer them, it is a bit 🤷
Contributor
|
r=me after nits |
…call in candidate
Contributor
Author
|
@bors r=lcnr |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2024
…iaskrgr Rollup of 2 pull requests Successful merges: - rust-lang#124444 (Record certainty of `evaluate_added_goals_and_make_canonical_response` call in candidate) - rust-lang#124463 (Rename `inhibit_union_abi_opt()` to `inhibits_union_abi_opt()`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2024
Rollup merge of rust-lang#124444 - compiler-errors:eval, r=lcnr Record certainty of `evaluate_added_goals_and_make_canonical_response` call in candidate Naming subject to bikeshedding, but I will need this when moving `select` to a proof tree visitor. r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming subject to bikeshedding, but I will need this when moving
selectto a proof tree visitor.r? lcnr