Closed
Conversation
In case the source is not in the same filesystem.
…types-improvement, r=pnkfelix `rustc --explain E0582` additional example ## Context *From rust-lang#124744* Expands the example for E0582, an error ensuring that lifetime in a function's return type is sufficiently constrained (e.g. actually tied to some input type), to show an additional example where one sees the lifetime occurring syntactically among the relevant function input types, but is nonetheless rejected by rustc because a syntactic occurrence is not always sufficient.
Use an helper to move the files In case the source is not in the same filesystem. See openwrt/packages@c1b3e04#commitcomment-141886468
…eyouxu Migrate `run-make/c-link-to-rust-staticlib` to `rmake` Part of rust-lang#121876. r? `@jieyouxu` try-job: dist-x86_64-freebsd
…ieril `rustc_hir_typeck`: Account for `skipped_ref_pats` in `expr_use_visitor` Fixes rust-lang#125058 r? `@Nadrieril` cc rust-lang#123076 `@rustbot` label A-edition-2024 A-patterns
Migrate `run-make/no-cdylib-as-rdylib` to `rmake` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). > "the test will fail if the cdylib is picked, because it doesn't export any rust symbols" Is that true? Is there a way to verify? I suggest maybe extending the test with: (after cleaning the directory) ```rust rustc() .input("bar.rs") .crate_type("cdylib") .run(); rustc() .input("foo.rs") .prefer_dynamic() .run(); fail(); ``` to make sure we're actually testing something here.
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#124746 (`rustc --explain E0582` additional example) - rust-lang#124975 (Use an helper to move the files) - rust-lang#125027 (Migrate `run-make/c-link-to-rust-staticlib` to `rmake`) - rust-lang#125084 (`rustc_hir_typeck`: Account for `skipped_ref_pats` in `expr_use_visitor`) - rust-lang#125104 (Migrate `run-make/no-cdylib-as-rdylib` to `rmake`) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
|
💔 Test failed - checks-actions |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc --explain E0582additional example #124746 (rustc --explain E0582additional example)run-make/c-link-to-rust-staticlibtormake#125027 (Migraterun-make/c-link-to-rust-staticlibtormake)rustc_hir_typeck: Account forskipped_ref_patsinexpr_use_visitor#125084 (rustc_hir_typeck: Account forskipped_ref_patsinexpr_use_visitor)run-make/no-cdylib-as-rdylibtormake#125104 (Migraterun-make/no-cdylib-as-rdylibtormake)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup