Remove an unloaded file with syntax errors.#12564
Remove an unloaded file with syntax errors.#12564chris-morgan wants to merge 1 commit intorust-lang:masterfrom
Conversation
“If it’s not in use, kill it.”
|
On Tue, Feb 25, 2014 at 11:05:03PM -0800, Chris Morgan wrote:
That...used to work. I guess it somehow never got linked into the |
|
Certainly fixing it is a reasonable choice, and preferable if the file is salvageable. I just submitted this PR as a convenient way of reporting it—removing it is nice and easy and it let me get on with my test of pretty printing all the Rust code from the Rust repository to find and fix bugs in the pretty printer. (The Travis CI build failure is spurious, by the way.) |
|
@nikomatsakis yeah I tried using it, found it didn't work, and said "oh well, niko must have been using this while the code was under development." I can probably fix it. |
|
Sounds like this file needs to be salvaged. I have opened #12585 on this topic. |
internal: Collapse completion ctx path `qualifier` and `is_absolute_path` into enum
…-12564, r=dswij [`manual_unwrap_or_default`]: Check for Default trait implementation in initial condition when linting and use `IfLetOrMatch` Fixes rust-lang#12564 changelog: Fix [`manual_unwrap_or_default`] false positive when initial `match`/`if let` condition doesn't implement `Default` but the return type does.
“If it’s not in use, kill it.”
I was just going and feeding everything through
rustc --pretty normal, and I guess this file isn't in use:cc @nikomatsakis