debuginfo: Fixes and improvements for #12840, #12886, and #13213#13441

michaelwoerister · 2014-04-10T14:06:33Z

This PR is a collection of debuginfo fixes and improvements:

Fixes Undefined reference with debug flag #13213: This is a bug where the linker could not find a global variable inlined from another crate because it was actually optimized out from the external crate. The fix makes sure that we don't create debuginfo for globals that are defined in other crates (even if there is a local, inlined copy of the global).
Fixes debuginfo: Extraneous descriptions of enum discriminator are emitted #12840: An optimization for sharing the type metadata of generic enum discriminators between monomorphized instances.
Should improve the situation for Line-based breakpoints set dozens of unwanted ones #12886 by making sure that inlined code is not linked to any source locations. I don't want to close the issue automatically as it needs some manual testing.

…ons. This commit makes sure that code inlined from other functions isn't assigned the source position of the call site, since this leads to undesired behavior when setting line breakpoints (issue rust-lang#12886)

An optimization for sharing the type metadata of generic enum discriminators between monomorphized instances (fixes issue rust-lang#12840)

Fixes issue rust-lang#13213, that is linker errors when the inlined static has been optimized out of the exporting crate.

…chton This is a test case verifying that issue #12886 was indeed fixed by PR #13441 from last week. Fixes #12886.

Add some sysroot logging

michaelwoerister added 3 commits April 10, 2014 12:16

debuginfo: Implement discriminator type metadata re-use.

e6800d2

An optimization for sharing the type metadata of generic enum discriminators between monomorphized instances (fixes issue rust-lang#12840)

debuginfo: Don't create debuginfo for statics inlined from other crates.

c5139a0

Fixes issue rust-lang#13213, that is linker errors when the inlined static has been optimized out of the exporting crate.

alexcrichton mentioned this pull request Apr 10, 2014

Rolling up PRs in the queue #13443

Closed

michaelwoerister mentioned this pull request Apr 10, 2014

Line-based breakpoints set dozens of unwanted ones #12886

Closed

bors closed this in 0156af1 Apr 11, 2014

This was referenced Apr 12, 2014

Undefined reference with debug flag #13213

Closed

debuginfo: Extraneous descriptions of enum discriminator are emitted #12840

Closed

debuginfo: Add a test case for issue #12886. #13556

Merged

bors added a commit that referenced this pull request Apr 16, 2014

auto merge of #13556 : michaelwoerister/rust/various-fixes, r=alexcri…

baa149b

…chton This is a test case verifying that issue #12886 was indeed fixed by PR #13441 from last week. Fixes #12886.

compiler-errors pushed a commit to compiler-errors/rust that referenced this pull request Oct 26, 2022

Auto merge of rust-lang#13441 - Veykril:sysroot-logging, r=Veykril

82ac6f7

Add some sysroot logging

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

debuginfo: Fixes and improvements for #12840, #12886, and #13213#13441