coverage: Rename basic_coverage_blocks to just graph#134551
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 20, 2024
Merged
coverage: Rename basic_coverage_blocks to just graph#134551bors merged 1 commit intorust-lang:masterfrom
basic_coverage_blocks to just graph#134551bors merged 1 commit intorust-lang:masterfrom
Conversation
During coverage instrumentation, this variable always holds the coverage graph, which is a simplified view of the MIR control-flow graph. The new name is clearer in context, and also shorter.
Zalathar
added
the
A-code-coverage
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
lqd
approved these changes
Dec 20, 2024
Member
lqd
left a comment
lqd
left a comment
There was a problem hiding this comment.
I guess coverage or coverage_graph could also be better than basic_coverage_blocks, but sure.
Member
Author
|
In the context of the InstrumentCoverage pass, everything is coverage, so just I can see an argument for |
Member
|
Sure, that was an approval. @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#134366 (Fix logical error with what text is considered whitespace.) - rust-lang#134514 (Improve dependency_format a bit) - rust-lang#134519 (ci: use ubuntu `24` instead of `latest`) - rust-lang#134551 (coverage: Rename `basic_coverage_blocks` to just `graph`) - rust-lang#134553 (add member constraints comment) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#134366 (Fix logical error with what text is considered whitespace.) - rust-lang#134514 (Improve dependency_format a bit) - rust-lang#134519 (ci: use ubuntu `24` instead of `latest`) - rust-lang#134551 (coverage: Rename `basic_coverage_blocks` to just `graph`) - rust-lang#134553 (add member constraints comment) r? `@ghost` `@rustbot` modify labels: rollup
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Dec 20, 2024
coverage: Rename `basic_coverage_blocks` to just `graph` During coverage instrumentation, this variable always holds the current function's coverage graph, which is a simplified view of its MIR control-flow graph. The new name is clearer in context, and also shorter. --- This is purely a rename, so there is no functional change.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup merge of rust-lang#134551 - Zalathar:graph, r=lqd coverage: Rename `basic_coverage_blocks` to just `graph` During coverage instrumentation, this variable always holds the current function's coverage graph, which is a simplified view of its MIR control-flow graph. The new name is clearer in context, and also shorter. --- This is purely a rename, so there is no functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During coverage instrumentation, this variable always holds the current function's coverage graph, which is a simplified view of its MIR control-flow graph. The new name is clearer in context, and also shorter.
This is purely a rename, so there is no functional change.