arm: add unstable soft-float target feature#135203
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 8, 2025
Merged
Conversation
Collaborator
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
arm-soft-float
branch
from
c9769e8 to
427abb6
Compare
jieyouxu
added
the
O-Arm
Member
|
Sure. I think we do want the hard-float feature or something close but that's a discussion for later, obviously, @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2025
…jubilee arm: add unstable soft-float target feature This has an actual usecase as mentioned [here](rust-lang#116344 (comment)), and with my recent ARM float ABI changes there shouldn't be any soundness concerns any more. We will reject enabling this feature on `hf` targets, but disabling it on non-`hf` targets is entirely fine -- the target feature refers to whether softfloat emulation is used for float instructions, and is independent of the ABI which we set separately via `llvm_floatabi`. Cc `@workingjubilee`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads) - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius) - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group) - rust-lang#135176 (More compelling env_clear() examples) - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target) - rust-lang#135203 (arm: add unstable soft-float target feature) - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads) - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius) - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group) - rust-lang#135176 (More compelling env_clear() examples) - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target) - rust-lang#135203 (arm: add unstable soft-float target feature) - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it) r? `@ghost` `@rustbot` modify labels: rollup try-job: i686-mingw
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#133057 (Impl String::into_chars) - rust-lang#134389 (Condvar: implement wait_timeout for targets without threads) - rust-lang#134920 (Convert typeck constraints in location-sensitive polonius) - rust-lang#135032 (triagebot: register `relnotes-interest-group` ping group) - rust-lang#135176 (More compelling env_clear() examples) - rust-lang#135184 (Reserve x18 register for aarch64 wrs vxworks target) - rust-lang#135203 (arm: add unstable soft-float target feature) - rust-lang#135219 (warn about broken simd not only on structs but also enums and unions when we didn't opt in to it) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2025
Rollup merge of rust-lang#135203 - RalfJung:arm-soft-float, r=workingjubilee arm: add unstable soft-float target feature This has an actual usecase as mentioned [here](rust-lang#116344 (comment)), and with my recent ARM float ABI changes there shouldn't be any soundness concerns any more. We will reject enabling this feature on `hf` targets, but disabling it on non-`hf` targets is entirely fine -- the target feature refers to whether softfloat emulation is used for float instructions, and is independent of the ABI which we set separately via `llvm_floatabi`. Cc ``@workingjubilee``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has an actual usecase as mentioned here, and with my recent ARM float ABI changes there shouldn't be any soundness concerns any more. We will reject enabling this feature on
hftargets, but disabling it on non-hftargets is entirely fine -- the target feature refers to whether softfloat emulation is used for float instructions, and is independent of the ABI which we set separately viallvm_floatabi.Cc @workingjubilee