cg_llvm: Reduce visibility of some items outside the llvm module#136721
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 11, 2025
Merged
cg_llvm: Reduce visibility of some items outside the llvm module#136721bors merged 1 commit intorust-lang:masterfrom
llvm module#136721bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
dpaoliello
changed the title
Zalathar
reviewed
Feb 8, 2025
Comment on lines
2
to
3
| #![expect(dead_code)] | ||
| #![expect(unreachable_pub)] |
Member
There was a problem hiding this comment.
I'm reluctant to do this, even temporarily, because it has the side-effect of disabling dead-code warnings throughout the whole module, even for things that should be warnings (e.g. an unused pub(crate) helper function).
And we would be unable to get rid of it until all of the unwanted warnings are fixed individually.
Member
There was a problem hiding this comment.
hmm. how do nested deny and expect work, exactly?
Member
There was a problem hiding this comment.
IIRC, expect behaves exactly like allow, except that it also emits an unfulfilled_lint_expectations (which is a warning by default) if it doesn't suppress anything.
So if you have warn/deny on an outer module, and then allow/expect on an inner module/item, the diagnostic is suppressed as you would expect.
Member
There was a problem hiding this comment.
If you mean nested in the other direction, I have no idea.
(But I have noticed that if I put #[allow(dead_code)] on an enum, and then #[warn(dead_code)] on one of its variants, there is no diagnostic even if that variant is unused. And if I replace the warn with expect, the expectation is violated.)
Contributor
Author
There was a problem hiding this comment.
Ok, removed this and re-added the workaround in lib.rs
dpaoliello
force-pushed
the
cleanllvm2
branch
from
00c4ef0 to
5f29273
Compare
Zalathar
changed the title
llvm module
Member
|
Looks good, thanks. @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 11, 2025
cg_llvm: Reduce visibility of some items outside the `llvm` module Next piece of rust-lang#135502 This reduces the visibility of items (other than those in the `llvm` module) so that dead code analysis will correctly identify unused items.
This was referenced Feb 11, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2025
Rollup of 11 pull requests Successful merges: - rust-lang#136606 (Fix long lines which rustfmt fails to format) - rust-lang#136663 (Stabilize `NonZero::count_ones`) - rust-lang#136672 (library: doc: core::alloc::Allocator: trivial typo fix) - rust-lang#136704 (Improve examples for file locking) - rust-lang#136721 (cg_llvm: Reduce visibility of some items outside the `llvm` module) - rust-lang#136813 (rustc_target: Add the fp16 target feature for AArch32) - rust-lang#136830 (fix i686-unknown-hurd-gnu x87 footnote) - rust-lang#136832 (Fix platform support table for i686-unknown-uefi) - rust-lang#136835 (Stop using span hack for contracts feature gating) - rust-lang#136837 (Overhaul how contracts are lowered on fn-like bodies) - rust-lang#136839 (fix ensure_monomorphic_enough) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2025
Rollup merge of rust-lang#136721 - dpaoliello:cleanllvm2, r=Zalathar cg_llvm: Reduce visibility of some items outside the `llvm` module Next piece of rust-lang#135502 This reduces the visibility of items (other than those in the `llvm` module) so that dead code analysis will correctly identify unused items.
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
Rollup of 11 pull requests Successful merges: - rust-lang#136606 (Fix long lines which rustfmt fails to format) - rust-lang#136663 (Stabilize `NonZero::count_ones`) - rust-lang#136672 (library: doc: core::alloc::Allocator: trivial typo fix) - rust-lang#136704 (Improve examples for file locking) - rust-lang#136721 (cg_llvm: Reduce visibility of some items outside the `llvm` module) - rust-lang#136813 (rustc_target: Add the fp16 target feature for AArch32) - rust-lang#136830 (fix i686-unknown-hurd-gnu x87 footnote) - rust-lang#136832 (Fix platform support table for i686-unknown-uefi) - rust-lang#136835 (Stop using span hack for contracts feature gating) - rust-lang#136837 (Overhaul how contracts are lowered on fn-like bodies) - rust-lang#136839 (fix ensure_monomorphic_enough) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
Rollup of 11 pull requests Successful merges: - rust-lang#136606 (Fix long lines which rustfmt fails to format) - rust-lang#136663 (Stabilize `NonZero::count_ones`) - rust-lang#136672 (library: doc: core::alloc::Allocator: trivial typo fix) - rust-lang#136704 (Improve examples for file locking) - rust-lang#136721 (cg_llvm: Reduce visibility of some items outside the `llvm` module) - rust-lang#136813 (rustc_target: Add the fp16 target feature for AArch32) - rust-lang#136830 (fix i686-unknown-hurd-gnu x87 footnote) - rust-lang#136832 (Fix platform support table for i686-unknown-uefi) - rust-lang#136835 (Stop using span hack for contracts feature gating) - rust-lang#136837 (Overhaul how contracts are lowered on fn-like bodies) - rust-lang#136839 (fix ensure_monomorphic_enough) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next piece of #135502
This reduces the visibility of items (other than those in the
llvmmodule) so that dead code analysis will correctly identify unused items.