Use defaults from formal type parameters in type inference, as fallbacks.#13702
Closed
eddyb wants to merge 3 commits intorust-lang:masterfrom
Closed
Use defaults from formal type parameters in type inference, as fallbacks.#13702eddyb wants to merge 3 commits intorust-lang:masterfrom
eddyb wants to merge 3 commits intorust-lang:masterfrom
Conversation
Contributor
|
@eddyb: needs a rebase |
Member
|
Closing due to inactivity, but feel free to reopen with a rebase! |
Contributor
|
👍 this is precisely what I need. Thank you. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 28, 2024
On arm64 I get ``` error[E0570]: `"vectorcall"` is not a supported ABI for the current target ``` We don't seem to be doing any ABI specific handling so it seems fine to just remove this one since there are other tests changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables more powerful uses of default type params, while maintaining backwards compatibility.
Disclaimer: the current implementation is only a proof of concept, missing substitution (for
<T, U = (T, T)>) and any form of lifetime environment (for<'a, T = &'a int>).Also, I somehow managed to break overriding the defaults (the last example doesn't actually compile).
It seems odd given that fallbacls should only be used when
force_tvaris set, and that shouldn't happen forlet v: Vec<_, char> = Vec::new();(otherwise our inference would be unusable).cc @nikomatsakis