Add reference annotations for the do_not_recommend attribute#137242
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 19, 2025
Merged
Add reference annotations for the do_not_recommend attribute#137242bors merged 1 commit intorust-lang:masterfrom
do_not_recommend attribute#137242bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Feb 18, 2025
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
Do we need so many tests tagged with attributes.diagnostic.do_not_recommend.intro? Surely choosing a simple one suffices?
Contributor
Author
|
Yea, we want the reference reader to be able to see all the different examples of how it can be used, and the different behaviors. (If it is the word "intro" that seems strange, don't think about that too much, we may restructure things in the future to not use that word for this purpose.) |
Contributor
|
ok @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 19, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#136936 (Use 'yes' instead of 'while-echo' in tests/ui/process/process-sigpipe.rs except 'nto') - rust-lang#137026 (Stabilize (and const-stabilize) `integer_sign_cast`) - rust-lang#137059 (fix: Alloc new errorcode E0803 for E0495) - rust-lang#137177 (Update `minifier-rs` version to `0.3.5`) - rust-lang#137210 (compiler: Stop reexporting stuff in cg_llvm::abi) - rust-lang#137213 (Remove `rustc_middle::mir::tcx` module.) - rust-lang#137216 (eval_outlives: bail out early if both regions are in the same SCC) - rust-lang#137228 (Fix typo in hidden internal docs of `TrustedRandomAccess`) - rust-lang#137242 (Add reference annotations for the `do_not_recommend` attribute) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 19, 2025
Rollup merge of rust-lang#137242 - ehuss:reference-do_not_recommend, r=compiler-errors Add reference annotations for the `do_not_recommend` attribute This adds reference rule identifiers for the tests of the `diagnostic::do_not_recommend` attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds reference rule identifiers for the tests of the
diagnostic::do_not_recommendattribute.