Fix typo in hir lowering lint diag#138518
Merged
bors merged 2 commits intorust-lang:masterfrom Mar 15, 2025
Merged
Conversation
Collaborator
Collaborator
|
HIR ty lowering was modified cc @fmease |
compiler-errors
suggested changes
Mar 14, 2025
Contributor
|
@rustbot author |
Contributor
Author
Right, sorry, was too hasty.
I agree that the phrasing isn't great. Too long, maybe? |
Contributor
|
maybe just
|
This comment has been minimized.
This comment has been minimized.
e61fd87 to
e6f7ab5
Compare
Contributor
Author
|
Updated diag text, and fixed a small grammar issue in an adjacent comment while I was at it |
compiler-errors
approved these changes
Mar 14, 2025
Contributor
|
a one-liner grammatical typo fix in a comment probably can just be folded into the first commit next time 🤔 @bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 15, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#138056 (rustc_target: Add target features for LoongArch v1.1) - rust-lang#138451 (Build GCC on CI with GCC, not Clang) - rust-lang#138454 (Improve post-merge workflow) - rust-lang#138460 (Pass struct field HirId when check_expr_struct_fields) - rust-lang#138474 (Refactor is_snake_case.) - rust-lang#138482 (Fix HIR printing of parameters) - rust-lang#138507 (Mirror NetBSD sources) - rust-lang#138511 (Make `Parser::parse_expr_cond` public) - rust-lang#138518 (Fix typo in hir lowering lint diag) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 15, 2025
Rollup merge of rust-lang#138518 - yotamofek:pr/hir-lint-typo, r=compiler-errors Fix typo in hir lowering lint diag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.