Move some things to rustc_type_ir#139722
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 14, 2025
Merged
Conversation
rustbot
added
S-waiting-on-review
compiler-errors
suggested changes
Apr 12, 2025
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
Looks mostly fine, just some questions and some nitpicky cleanups that would be really nice
| [] name_set: rustc_data_structures::unord::UnordSet<rustc_span::Symbol>, | ||
| [] autodiff_item: rustc_ast::expand::autodiff_attrs::AutoDiffItem, | ||
| [] ordered_name_set: rustc_data_structures::fx::FxIndexSet<rustc_span::Symbol>, | ||
| [] pats: rustc_middle::ty::PatternKind<'tcx>, |
Contributor
There was a problem hiding this comment.
I assume this was just never used?
Member
Author
There was a problem hiding this comment.
So, the IntoKind impl wants PatternKind to be Copy, so I added that derive, but then there are overlapping arena impls, so I just removed this.
Contributor
There was a problem hiding this comment.
Oh, right, as soon as an impl is copy it's automatically arena internable.
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rust-cloud-vms
bot
force-pushed
the
patternkind-walk-toir
branch
from
139f120 to
4d76429
Compare
rustbot
added
A-rustdoc-search
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor changes to the core type system changes to the core type system |
rust-cloud-vms
bot
force-pushed
the
patternkind-walk-toir
branch
from
4d76429 to
10955ec
Compare
Member
Author
|
@compiler-errors Sorry, I had fixed some of the things you commented on and pushed, but to the wrong branch. Looking at your review and will fix the things that are relevant. |
rust-cloud-vms
bot
force-pushed
the
patternkind-walk-toir
branch
from
10955ec to
accae53
Compare
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jackh726
removed
A-rustdoc-search
compiler-errors
approved these changes
Apr 13, 2025
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 13, 2025
…compiler-errors Move some things to rustc_type_ir This moves - `PatternKind` - `FlagComputation` - `TypeWalker` into rustc_type_ir. Not strictly required for rust-analyzer next-solve integration, but helps with code duplication. r? types
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 13, 2025
…compiler-errors Move some things to rustc_type_ir This moves - `PatternKind` - `FlagComputation` - `TypeWalker` into rustc_type_ir. Not strictly required for rust-analyzer next-solve integration, but helps with code duplication. r? types
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2025
…enton Rollup of 12 pull requests Successful merges: - rust-lang#138744 (Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678)) - rust-lang#138962 (Expect an array when expected and acutal types are both arrays during cast) - rust-lang#139001 (add `naked_functions_rustic_abi` feature gate) - rust-lang#139379 (Use delayed bug for normalization errors in drop elaboration) - rust-lang#139582 (Various coercion cleanups) - rust-lang#139628 (Suggest remove redundant `$()?` around `vis`) - rust-lang#139644 (Micro-optimize `InstSimplify`'s `simplify_primitive_clone`) - rust-lang#139666 (cleanup `mir_borrowck`) - rust-lang#139674 (In `rustc_mir_transform`, iterate over index newtypes instead of ints) - rust-lang#139695 (compiletest: consistently use `camino::{Utf8Path,Utf8PathBuf}` throughout) - rust-lang#139722 (Move some things to rustc_type_ir) - rust-lang#139740 (Convert `tests/ui/lint/dead-code/self-assign.rs` to a known-bug test) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#138336 (Improve `-Z crate-attr` diagnostics) - rust-lang#139636 (Encode dep node edge count as u32 instead of usize) - rust-lang#139666 (cleanup `mir_borrowck`) - rust-lang#139695 (compiletest: consistently use `camino::{Utf8Path,Utf8PathBuf}` throughout) - rust-lang#139699 (Proactively update coroutine drop shim's phase to account for later passes applied during shim query) - rust-lang#139718 (enforce unsafe attributes in pre-2024 editions by default) - rust-lang#139722 (Move some things to rustc_type_ir) - rust-lang#139760 (UI tests: migrate remaining compile time `error-pattern`s to line annotations when possible) - rust-lang#139776 (Switch attrs to `diagnostic::on_unimplemented`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2025
Rollup merge of rust-lang#139722 - jackh726:patternkind-walk-toir, r=compiler-errors Move some things to rustc_type_ir This moves - `PatternKind` - `FlagComputation` - `TypeWalker` into rustc_type_ir. Not strictly required for rust-analyzer next-solve integration, but helps with code duplication. r? types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves
PatternKindFlagComputationTypeWalkerinto rustc_type_ir.
Not strictly required for rust-analyzer next-solve integration, but helps with code duplication.
r? types