Skip to content

Specify --print info=file syntax in --help#139799

Merged
bors merged 1 commit intorust-lang:masterfrom
clubby789:print=file
Apr 15, 2025
Merged

Specify --print info=file syntax in --help#139799
bors merged 1 commit intorust-lang:masterfrom
clubby789:print=file

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Apr 14, 2025

Closes #139794

I moved the listing of information that can be printed to the help string as it's getting rather long and it makes the [=FILE] part easier to see

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2025

This PR modifies run-make tests.

cc @jieyouxu

jieyouxu
jieyouxu approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes look good to me. I wonder if you need to adjust one of the ui test normalizations, but r=me if PR CI is green.

@jieyouxu jieyouxu added the A-print-requests Area: print requests (`--print=...`) label Apr 14, 2025
@clubby789
Copy link
Contributor Author

clubby789 commented Apr 14, 2025

While here I notice that the emit option has the same problem:

        --emit [asm|llvm-bc|llvm-ir|obj|metadata|link|dep-info|mir]
                        Comma separated list of types of output for the
                        compiler to emit

Though I'm not sure of concise way to explain the intricacies of how the various output types interact with an output path

@jieyouxu
Copy link
Member

jieyouxu commented Apr 14, 2025 •
edited
Loading

Hm yeah. Can you open a separate issue for that?

E.g. https://doc.rust-lang.org/rustc/command-line-arguments.html?highlight=--emit#emitting-to-stdout

jieyouxu
jieyouxu reviewed Apr 14, 2025
View reviewed changes
tests/run-make/rustc-help/help.stdout
Comment on lines +32 to +33
--print INFO[=FILE]
Compiler information to print on stdout (or to a file)
Copy link
Member

@jieyouxu jieyouxu Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: for consistency reasons, - (as in stdout) is also accepted in the =FILE position, i.e. the following is a valid construct

$ rustc --print=target-cpus=-

and prints to stdout.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Apr 14, 2025

Yeah, r=me after reblessing some of the ui tests

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2025
@clubby789
Copy link
Contributor Author

clubby789 commented Apr 14, 2025

@bors r=jieyouxu rollup

@bors
Copy link
Collaborator

bors commented Apr 14, 2025

📌 Commit 1b46969 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 14, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 14, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2025
@bors
Auto merge of rust-lang#139826 - matthiaskrgr:rollup-0q0qvkd, r=matth…
7a6dca1 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139745 (Avoid unused clones in `Cloned<I>` and `Copied<I>`)
 - rust-lang#139757 (opt-dist: use executable-extension for host llvm-profdata)
 - rust-lang#139778 (Add test for issue 34834)
 - rust-lang#139783 (Use `compiletest-ignore-dir` for bootstrap self-tests)
 - rust-lang#139797 (Allow (but don't require) `#[unsafe(naked)]` so that `compiler-builtins` can upgrade to it)
 - rust-lang#139799 (Specify `--print info=file` syntax in `--help`)
 - rust-lang#139811 (Use `newtype_index!`-generated types more idiomatically)
 - rust-lang#139813 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 15, 2025
@Zalathar
Rollup merge of rust-lang#139799 - clubby789:print=file, r=jieyouxu
9551264 
Specify `--print info=file` syntax in `--help`

Closes rust-lang#139794

I moved the listing of information that can be printed to the help string as it's getting rather long and it makes the `[=FILE]` part easier to see
@Zalathar Zalathar mentioned this pull request Apr 15, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2025
@bors
Auto merge of rust-lang#139838 - Zalathar:rollup-dxhgi8t, r=Zalathar
96e9535 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#139669 (Overhaul `AssocItem`)
 - rust-lang#139671 (Proc macro span API redesign: Replace proc_macro::SourceFile by Span::{file, local_file})
 - rust-lang#139750 (std/thread: Use default stack size from menuconfig for NuttX)
 - rust-lang#139785 (Let CStrings be either 1 or 2 byte aligned.)
 - rust-lang#139797 (Allow (but don't require) `#[unsafe(naked)]` so that `compiler-builtins` can upgrade to it)
 - rust-lang#139798 (normalize: prefer `ParamEnv` over `AliasBound` candidates)
 - rust-lang#139799 (Specify `--print info=file` syntax in `--help`)
 - rust-lang#139811 (Use `newtype_index!`-generated types more idiomatically)
 - rust-lang#139813 (Miri subtree update)
 - rust-lang#139822 (Fix: Map EOPNOTSUPP to ErrorKind::Unsupported on Unix)
 - rust-lang#139836 (Basic tests of MPMC receiver cloning)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2025
@bors
Auto merge of rust-lang#139826 - matthiaskrgr:rollup-0q0qvkd, r=matth…
58c2dd9 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139745 (Avoid unused clones in `Cloned<I>` and `Copied<I>`)
 - rust-lang#139757 (opt-dist: use executable-extension for host llvm-profdata)
 - rust-lang#139778 (Add test for issue 34834)
 - rust-lang#139783 (Use `compiletest-ignore-dir` for bootstrap self-tests)
 - rust-lang#139797 (Allow (but don't require) `#[unsafe(naked)]` so that `compiler-builtins` can upgrade to it)
 - rust-lang#139799 (Specify `--print info=file` syntax in `--help`)
 - rust-lang#139811 (Use `newtype_index!`-generated types more idiomatically)
 - rust-lang#139813 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7dc3fec into rust-lang:master Apr 15, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 15, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2025
@rust-timer
Unrolled build for rust-lang#139799
3d99991 
Rollup merge of rust-lang#139799 - clubby789:print=file, r=jieyouxu

Specify `--print info=file` syntax in `--help`

Closes rust-lang#139794

I moved the listing of information that can be printed to the help string as it's getting rather long and it makes the `[=FILE]` part easier to see
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-print-requests Area: print requests (`--print=...`) A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

rustc --print=foo=file is not documented in rustc --help -v

5 participants

@clubby789 @rustbot @jieyouxu @rust-log-analyzer @bors