Exhaustively handle parsed attributes in CheckAttr#140372

mejrs · 2025-04-27T19:51:27Z

This pr

Deletes the unused DiagnosticAttribute struct and variant
Comments the AttributeKind enum
The match in CheckAttrVisitor is now exhaustive for AttributeKind::Parsed.
Moved some checks around after that change

I did not thoroughly check that there's no duplicated logic between this pass and the attribute parsing but I think it's OK.

r? @jdonszelmann

rustbot · 2025-04-27T19:51:32Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

compiler/rustc_attr_data_structures/src/attributes.rs

mejrs · 2025-04-28T14:24:15Z

Thanks @jieyouxu . I think I read the CI error wrong and that's why I added the <> 😆

mejrs · 2025-06-03T10:45:01Z

r? compiler

jdonszelmann · 2025-06-04T07:00:09Z

I'm sorry for the long wait, however I finally started getting time to review these so I took it back and will review today :)

compiler/rustc_attr_data_structures/src/attributes.rs

jdonszelmann · 2025-06-06T09:17:05Z

compiler/rustc_attr_data_structures/src/attributes.rs

    }
 }

-#[derive(Clone, Debug, Encodable, Decodable, HashStable_Generic, PrintAttribute)]


I'll add this back in soon, but that's ok

I'd like to do that actually, I just thought there shouldn't be a bunch of dead code here at this time.

I agree, and feel free to. I just filed #138164, #138165 and #138291 which might help with that

jdonszelmann · 2025-06-06T09:18:01Z

Some minor comments, but looks good overall

jdonszelmann · 2025-06-06T09:18:07Z

@rustbot author

rustbot · 2025-06-06T09:18:11Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

mejrs · 2025-06-06T10:40:53Z

@rustbot ready

jdonszelmann · 2025-06-09T23:15:56Z

bors · 2025-06-09T23:15:59Z

📌 Commit 5fdacfe has been approved by jdonszelmann

It is now in the queue for this repository.

jdonszelmann · 2025-06-09T23:16:38Z

@bors rollup

Exhaustively handle parsed attributes in CheckAttr This pr - Deletes the unused `DiagnosticAttribute ` struct and variant - Comments the `AttributeKind ` enum - The match in `CheckAttrVisitor` is now exhaustive for `AttributeKind::Parsed`. - Moved some checks around after that change I did *not* thoroughly check that there's no duplicated logic between this pass and the attribute parsing but I think it's OK. r? `@jdonszelmann`

Rollup of 13 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141061 (Change __rust_no_alloc_shim_is_unstable to be a function) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142101 (core::ptr: deduplicate more method docs) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142260 (Miri subtree update) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142275 (rustdoc: Refractor `clean_ty_generics`) r? `@ghost` `@rustbot` modify labels: rollup

Exhaustively handle parsed attributes in CheckAttr This pr - Deletes the unused `DiagnosticAttribute ` struct and variant - Comments the `AttributeKind ` enum - The match in `CheckAttrVisitor` is now exhaustive for `AttributeKind::Parsed`. - Moved some checks around after that change I did *not* thoroughly check that there's no duplicated logic between this pass and the attribute parsing but I think it's OK. r? ``@jdonszelmann``

Rollup of 12 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141061 (Change __rust_no_alloc_shim_is_unstable to be a function) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142101 (core::ptr: deduplicate more method docs) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142260 (Miri subtree update) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142275 (rustdoc: Refractor `clean_ty_generics`) r? `@ghost` `@rustbot` modify labels: rollup

Exhaustively handle parsed attributes in CheckAttr This pr - Deletes the unused `DiagnosticAttribute ` struct and variant - Comments the `AttributeKind ` enum - The match in `CheckAttrVisitor` is now exhaustive for `AttributeKind::Parsed`. - Moved some checks around after that change I did *not* thoroughly check that there's no duplicated logic between this pass and the attribute parsing but I think it's OK. r? ```@jdonszelmann```

Rollup of 14 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141642 (Note the version and PR of removed features when using it) - #141909 (Add central execution context to bootstrap) - #141992 (use `#[naked]` for `__rust_probestack`) - #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods) - #142124 (Allow transmute casts in pre-runtime-MIR) - #142240 (deduplicate the rest of AST walker functions) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142271 (compiler: fn ptrs should hit different lints based on ABI) - #142288 (const_eval: fix some outdated comments) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 16 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141642 (Note the version and PR of removed features when using it) - #141818 (Don't create .msi installer for gnullvm hosts) - #141909 (Add central execution context to bootstrap) - #141992 (use `#[naked]` for `__rust_probestack`) - #142101 (core::ptr: deduplicate more method docs) - #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods) - #142124 (Allow transmute casts in pre-runtime-MIR) - #142240 (deduplicate the rest of AST walker functions) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142271 (compiler: fn ptrs should hit different lints based on ABI) - #142275 (rustdoc: Refractor `clean_ty_generics`) - #142288 (const_eval: fix some outdated comments) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #140372 - mejrs:attrs, r=jdonszelmann Exhaustively handle parsed attributes in CheckAttr This pr - Deletes the unused `DiagnosticAttribute ` struct and variant - Comments the `AttributeKind ` enum - The match in `CheckAttrVisitor` is now exhaustive for `AttributeKind::Parsed`. - Moved some checks around after that change I did *not* thoroughly check that there's no duplicated logic between this pass and the attribute parsing but I think it's OK. r? ````@jdonszelmann````

Rollup of 16 pull requests Successful merges: - rust-lang/rust#134442 (Specify the behavior of `file!`) - rust-lang/rust#140372 (Exhaustively handle parsed attributes in CheckAttr) - rust-lang/rust#140766 (Stabilize keylocker) - rust-lang/rust#141642 (Note the version and PR of removed features when using it) - rust-lang/rust#141818 (Don't create .msi installer for gnullvm hosts) - rust-lang/rust#141909 (Add central execution context to bootstrap) - rust-lang/rust#141992 (use `#[naked]` for `__rust_probestack`) - rust-lang/rust#142101 (core::ptr: deduplicate more method docs) - rust-lang/rust#142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods) - rust-lang/rust#142124 (Allow transmute casts in pre-runtime-MIR) - rust-lang/rust#142240 (deduplicate the rest of AST walker functions) - rust-lang/rust#142258 (platform-support.md: Mention specific Linux kernel version or later) - rust-lang/rust#142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - rust-lang/rust#142271 (compiler: fn ptrs should hit different lints based on ABI) - rust-lang/rust#142275 (rustdoc: Refractor `clean_ty_generics`) - rust-lang/rust#142288 (const_eval: fix some outdated comments) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jdonszelmann Apr 27, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2025

mejrs force-pushed the attrs branch from c249885 to d01e5b2 Compare April 27, 2025 19:59

This comment has been minimized.

Sign in to view

mejrs force-pushed the attrs branch from d01e5b2 to 4d57ec1 Compare April 27, 2025 20:44

jieyouxu reviewed Apr 28, 2025

View reviewed changes

mejrs force-pushed the attrs branch 2 times, most recently from e88b142 to 2e609cd Compare April 28, 2025 14:22

mejrs changed the title ~~Force exhaustive handling of parsed attributes~~ Exhaustively handle parsed attributes in CheckAttr Apr 29, 2025

rustbot assigned BoxyUwU and unassigned jdonszelmann Jun 3, 2025

jdonszelmann assigned jdonszelmann and unassigned BoxyUwU Jun 4, 2025

jdonszelmann reviewed Jun 6, 2025

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 6, 2025

jdonszelmann mentioned this pull request Jun 6, 2025

Refactor rustc_attr_data_structures documentation #142082

Merged

mejrs force-pushed the attrs branch from 2e609cd to 3c7d7db Compare June 6, 2025 09:39

This comment has been minimized.

Sign in to view

mejrs force-pushed the attrs branch from 3c7d7db to 7842066 Compare June 6, 2025 09:42

Delete unused variant and document AttributeKind

dc14e73

Force exhaustive handling of every parsed attribute

5fdacfe

mejrs force-pushed the attrs branch from 7842066 to 5fdacfe Compare June 6, 2025 09:43

jdonszelmann added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2025

workingjubilee mentioned this pull request Jun 10, 2025

Rollup of 13 pull requests #142278

Closed

workingjubilee mentioned this pull request Jun 10, 2025

Rollup of 12 pull requests #142283

Closed

fmease mentioned this pull request Jun 10, 2025

Rollup of 14 pull requests #142290

Closed

fmease mentioned this pull request Jun 10, 2025

Rollup of 16 pull requests #142299

Merged

bors merged commit 0f16ccb into rust-lang:master Jun 10, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 10, 2025

Uh oh!

Conversation

mejrs commented Apr 27, 2025

Uh oh!

rustbot commented Apr 27, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mejrs commented Apr 28, 2025

Uh oh!

mejrs commented Jun 3, 2025

Uh oh!

jdonszelmann commented Jun 4, 2025

Uh oh!

Uh oh!

jdonszelmann Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

mejrs Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Jun 6, 2025

Uh oh!

jdonszelmann commented Jun 6, 2025

Uh oh!

rustbot commented Jun 6, 2025

Uh oh!

This comment has been minimized.

mejrs commented Jun 6, 2025

Uh oh!

jdonszelmann commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jun 9, 2025

Uh oh!

jdonszelmann commented Jun 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jdonszelmann commented Jun 9, 2025 •

edited

Loading