Skip to content

Use crate:: prefix for root macro suggestions#141132

Merged
bors merged 1 commit intorust-lang:masterfrom
bvanjoi:issue-141082
May 18, 2025
Merged

Use crate:: prefix for root macro suggestions#141132
bors merged 1 commit intorust-lang:masterfrom
bvanjoi:issue-141082

Conversation

@bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented May 17, 2025

Fixes #141082

I've changed the prefix to crate directly, since it's compatible across all editions.

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 17, 2025
fmease
fmease reviewed May 17, 2025
View reviewed changes
fmease
fmease reviewed May 17, 2025
View reviewed changes
@fmease fmease assigned fmease and unassigned fee1-dead May 17, 2025
@fmease
Copy link
Member

fmease commented May 17, 2025 •
edited
Loading

Eh, my 'concern' is negligible. Thanks! :)

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 524021c has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
@bvanjoi
Copy link
Contributor Author

bvanjoi commented May 17, 2025

I agree with these suggestions and will:

  • Use the revision in issue-99695.rs
  • Create a new issue to propose changing use to pub use

@fmease
Copy link
Member

fmease commented May 17, 2025

Ok :)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 17, 2025
fmease
fmease reviewed May 17, 2025
View reviewed changes
@fmease
Copy link
Member

fmease commented May 17, 2025

Thanks :)
@bors r+

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 1adfdb4 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 17, 2025
jieyouxu
jieyouxu reviewed May 17, 2025
View reviewed changes
tests/ui/imports/issue-99695.rs
Copy link
Member

@jieyouxu jieyouxu May 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: while you're modifying this test, can you please rename it to sth more meaningful? We can still keep a backlink to the issue in a doc comment.

Actually nvm, this is in the queue already. I can do that as a follow-up.

fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#141132 - bvanjoi:issue-141082, r=fmease
a94cf15 
Use `crate::` prefix for root macro suggestions

Fixes rust-lang#141082

I've changed the prefix to `crate` directly, since it's compatible across all editions.
@fmease fmease mentioned this pull request May 18, 2025
Closed
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#141132 - bvanjoi:issue-141082, r=fmease
9ee320b 
Use `crate::` prefix for root macro suggestions

Fixes rust-lang#141082

I've changed the prefix to `crate` directly, since it's compatible across all editions.
@fmease fmease mentioned this pull request May 18, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#141209 - fmease:rollup-s1ck9vb, r=fmease
f3dd06e 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#140113 (Add per page TOC in the `rustc` book)
 - rust-lang#140490 (split `asm!` parsing and validation)
 - rust-lang#140924 (Make some `f32`/`f64` tests also run in const-context)
 - rust-lang#141045 ([win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test)
 - rust-lang#141071 (Enable [behind-upstream] triagebot option for rust-lang/rust)
 - rust-lang#141132 (Use `crate::` prefix for root macro suggestions)
 - rust-lang#141139 (Fix Rust for Linux ping group label)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request May 18, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#141216 - fmease:rollup-pa5mvx3, r=fmease
b53e5c9 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#140113 (Add per page TOC in the `rustc` book)
 - rust-lang#140511 (Stabilize `#![feature(non_null_from_ref)]`)
 - rust-lang#140924 (Make some `f32`/`f64` tests also run in const-context)
 - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
 - rust-lang#141045 ([win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test)
 - rust-lang#141071 (Enable [behind-upstream] triagebot option for rust-lang/rust)
 - rust-lang#141132 (Use `crate::` prefix for root macro suggestions)
 - rust-lang#141139 (Fix Rust for Linux ping group label)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b89118a into rust-lang:master May 18, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 18, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@rust-timer
Unrolled build for rust-lang#141132
780fd26 
Rollup merge of rust-lang#141132 - bvanjoi:issue-141082, r=fmease

Use `crate::` prefix for root macro suggestions

Fixes rust-lang#141082

I've changed the prefix to `crate` directly, since it's compatible across all editions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease approved these changes

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@fmease fmease

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

suggestion/fix (use ::item) is incorrect for editions 2018+

6 participants

@bvanjoi @rustbot @fmease @bors @jieyouxu @fee1-dead