std: add assert_equiv!() macro, and update StrBuf tests#14120
Closed
erickt wants to merge 1 commit intorust-lang:masterfrom
Closed
std: add assert_equiv!() macro, and update StrBuf tests#14120erickt wants to merge 1 commit intorust-lang:masterfrom
assert_equiv!() macro, and update StrBuf tests#14120erickt wants to merge 1 commit intorust-lang:masterfrom
Conversation
Member
|
We ended up removing the semi-similar cousin |
Member
|
Closing due to inactivity, but feel free to reopen with a rebase! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
internal: Revert castable expectation and simplify Unfixes rust-lang/rust-analyzer#11571, the PR for that introduced some regressions (tried fixing them but doing what rustc does there specifically does not help, probably because something else affects it as well there)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2023
Properly infer types with type casts This PR reenables `Expectation::Castable` (previous attempt at rust-lang#14104, reverted by rust-lang#14120) and implements type cast checks, which enable us to infer a bit more. Castable expectations are relatively weak -- they only influence the inference if we cannot infer the types by other means. Therefore, we need to defer possible type unification with the casted type until we type check all expressions of the body. This PR adds a struct and slots in `InferenceContext` for the deferred cast checks (c.f. [`CastCheck`] in `rustc_hir_typeck`). I only implemented the bits that affect the inference result. It should be possible to return type adjustments for well-formed casts and report diagnostics for invalid casts, but I'm leaving them for future work for now. Fixes rust-lang#11571 Fixes rust-lang#15246 [`CastCheck`]: https://github.com/rust-lang/rust/blob/da1d099f91ea387a2814a6244dd875a2048b486f/compiler/rustc_hir_typeck/src/cast.rs#L55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
assert_equiv!()macro that allows two items that are not of the same time, but implement theEquivtrait to see if they are equivalent. This simplifies comparingStrBufand&strtypes. Along with this patch, it implementsEquivforStrBuf, and rewrites some of the tests to useassert_equiv!().