Skip to content

Fix AIX build#142091

Merged
bors merged 1 commit intorust-lang:masterfrom
thaliaarchi:aix-getenv
Jun 6, 2025
Merged

Fix AIX build#142091
bors merged 1 commit intorust-lang:masterfrom
thaliaarchi:aix-getenv

Conversation

@thaliaarchi
Copy link
Contributor

@thaliaarchi thaliaarchi commented Jun 5, 2025 •
edited by rustbot
Loading

Fix #141543.

getenv was moved out of this file to sys::env::getenv in #140143. Replace its usage with std::env::var_os, the publicly exposed version. This matches the other usages of the same function in this file.

@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 5, 2025
@thaliaarchi thaliaarchi mentioned this pull request Jun 5, 2025
Closed
@workingjubilee
Copy link
Member

workingjubilee commented Jun 5, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 5, 2025

📌 Commit 46ce08e has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2025
@gilamn5tr
Copy link

gilamn5tr commented Jun 5, 2025

Thank you. I had the fix but just hadn't got around to pushing it.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 5, 2025
@GuillaumeGomez
Rollup merge of rust-lang#142091 - thaliaarchi:aix-getenv, r=workingj…
a1e3c25 
…ubilee

Fix AIX build

Fix rust-lang#141543.

`getenv` was moved out of this file to `sys::env::getenv` in rust-lang#140143. Replace its usage with `std::env::var_os`, the publicly exposed version. This matches the other usages of the same function in this file.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 5, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 5, 2025
Merged
bors added a commit that referenced this pull request Jun 6, 2025
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
2082a82 
Rollup of 11 pull requests

Successful merges:

 - #125087 (Optimize `Seek::stream_len` impl for `File`)
 - #141982 (`tests/ui`: A New Order [5/N])
 - #142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - #142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - #142047 (Ensure stack in two places that affect s390x)
 - #142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - #142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - #142072 (doc: Fix inverted meaning in E0783.md)
 - #142084 (add myself to rotation)
 - #142091 (Fix AIX build)
 - #142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - #142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 6, 2025
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
16ca0cb 
Rollup of 11 pull requests

Successful merges:

 - #125087 (Optimize `Seek::stream_len` impl for `File`)
 - #141982 (`tests/ui`: A New Order [5/N])
 - #142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - #142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - #142047 (Ensure stack in two places that affect s390x)
 - #142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - #142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - #142072 (doc: Fix inverted meaning in E0783.md)
 - #142084 (add myself to rotation)
 - #142091 (Fix AIX build)
 - #142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - #142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 6, 2025
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
f315e61 
Rollup of 11 pull requests

Successful merges:

 - #125087 (Optimize `Seek::stream_len` impl for `File`)
 - #141982 (`tests/ui`: A New Order [5/N])
 - #142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - #142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - #142047 (Ensure stack in two places that affect s390x)
 - #142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - #142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - #142072 (doc: Fix inverted meaning in E0783.md)
 - #142084 (add myself to rotation)
 - #142091 (Fix AIX build)
 - #142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - #142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9c89555 into rust-lang:master Jun 6, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 6, 2025
rust-timer added a commit that referenced this pull request Jun 6, 2025
@rust-timer
Unrolled build for #142091
990dc19 
Rollup merge of #142091 - thaliaarchi:aix-getenv, r=workingjubilee

Fix AIX build

Fix #141543.

`getenv` was moved out of this file to `sys::env::getenv` in #140143. Replace its usage with `std::env::var_os`, the publicly exposed version. This matches the other usages of the same function in this file.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 7, 2025
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
d6ea7d2 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#125087 (Optimize `Seek::stream_len` impl for `File`)
 - rust-lang/rust#141982 (`tests/ui`: A New Order [5/N])
 - rust-lang/rust#142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - rust-lang/rust#142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - rust-lang/rust#142047 (Ensure stack in two places that affect s390x)
 - rust-lang/rust#142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - rust-lang/rust#142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - rust-lang/rust#142072 (doc: Fix inverted meaning in E0783.md)
 - rust-lang/rust#142084 (add myself to rotation)
 - rust-lang/rust#142091 (Fix AIX build)
 - rust-lang/rust#142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - rust-lang/rust#142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 17, 2025
@matthiaskrgr
Rollup merge of rust-lang#142091 - thaliaarchi:aix-getenv, r=workingj…
d70aec0 
…ubilee

Fix AIX build

Fix rust-lang#141543.

`getenv` was moved out of this file to `sys::env::getenv` in rust-lang#140143. Replace its usage with `std::env::var_os`, the publicly exposed version. This matches the other usages of the same function in this file.
@thaliaarchi thaliaarchi deleted the aix-getenv branch June 26, 2025 21:38
@xingxue-ibm
Copy link
Contributor

xingxue-ibm commented Jul 4, 2025

Suggest backporting to the stable branch, as this fixes the issue that broke the v1.88 build on AIX.

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

Error: Label stable-nominated can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@xingxue-ibm
Copy link
Contributor

xingxue-ibm commented Jul 4, 2025 •
edited
Loading

Error: Label stable-nominated can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Hi @workingjubilee, would you be able to help set the stable-nominated label?

@xingxue-ibm
Copy link
Contributor

xingxue-ibm commented Jul 5, 2025 •
edited
Loading

Error: Label stable-nominated can only be set by Rust team members
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Hi @workingjubilee, would you be able to help set the stable-nominated label?

Never mind. It is included in v1.89 and we will cherry-pick it into the local v1.88 branch.

christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
cc5c777 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#125087 (Optimize `Seek::stream_len` impl for `File`)
 - rust-lang/rust#141982 (`tests/ui`: A New Order [5/N])
 - rust-lang/rust#142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - rust-lang/rust#142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - rust-lang/rust#142047 (Ensure stack in two places that affect s390x)
 - rust-lang/rust#142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - rust-lang/rust#142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - rust-lang/rust#142072 (doc: Fix inverted meaning in E0783.md)
 - rust-lang/rust#142084 (add myself to rotation)
 - rust-lang/rust#142091 (Fix AIX build)
 - rust-lang/rust#142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - rust-lang/rust#142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
40e12d7 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#125087 (Optimize `Seek::stream_len` impl for `File`)
 - rust-lang/rust#141982 (`tests/ui`: A New Order [5/N])
 - rust-lang/rust#142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - rust-lang/rust#142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - rust-lang/rust#142047 (Ensure stack in two places that affect s390x)
 - rust-lang/rust#142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - rust-lang/rust#142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - rust-lang/rust#142072 (doc: Fix inverted meaning in E0783.md)
 - rust-lang/rust#142084 (add myself to rotation)
 - rust-lang/rust#142091 (Fix AIX build)
 - rust-lang/rust#142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - rust-lang/rust#142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ibraheemdev ibraheemdev

Labels

O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

AIX fails to build

7 participants

@thaliaarchi @rustbot @workingjubilee @bors @gilamn5tr @xingxue-ibm @ibraheemdev