[COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary#143229

jieyouxu · 2025-06-30T07:25:54Z

This is part of a patch series to untangle compiletest to hopefully nudge it towards being more maintainable.

This PR:

Moves some early config checks (some warnings) to the compiletest library.
Moves src/main.rs to src/bin/main.rs to make the separation (as in, compiletest's library component vs the tool binary component) more obvious.

r? @Kobzol (or reroll)

To make it obvious `compiletest`-the-tool has two components: 1. The core compiletest library, and 2. The tool binary, which will be executed by bootstrap.

Kobzol · 2025-06-30T11:50:13Z

I'd probably just keep the "binary-only code" in the binary (the first commit), but it's a small thing.

Feel free to r=me.

jieyouxu · 2025-06-30T13:10:15Z

I'd probably just keep the "binary-only code" in the binary (the first commit), but it's a small thing.

FWIW, I moved that because it feels like they belong to the same "early configuration check". I want to revisit how the config is actually "finalized" (it's not only from cli args). I'm expecting a few more early config checks, and lib.rs isn't the intended eventual destination for these.

(This is more of an intermediate thing.)

jieyouxu · 2025-06-30T13:12:34Z

@bors r=Kobzol rollup

bors · 2025-06-30T13:12:36Z

📌 Commit e664e7e has been approved by Kobzol

It is now in the queue for this repository.

…, r=Kobzol [COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary This is part of a patch series to untangle `compiletest` to hopefully nudge it towards being more maintainable. This PR: - Moves some early config checks (some warnings) to the compiletest library. - Moves `src/main.rs` to `src/bin/main.rs` to make the separation (as in, compiletest's library component vs the tool binary component) more obvious. r? `@Kobzol` (or reroll)

Rollup of 5 pull requests Successful merges: - #143156 (inherit `#[align]` from trait method prototypes) - #143223 (Improve macro stats printing) - #143229 ([COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary) - #143239 (GCC backend subtree update) - #143246 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - #143019 (Ensure -V --verbose processes both codegen_backend and codegen-backend) - #143140 (give Pointer::into_parts a more scary name and offer a safer alternative) - #143175 (Make combining LLD with external LLVM config a hard error) - #143180 (Use `tracing-forest` instead of `tracing-tree` for bootstrap tracing) - #143223 (Improve macro stats printing) - #143228 (Handle build scripts better in `-Zmacro-stats` output.) - #143229 ([COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary) - #143246 (Subtree update of `rust-analyzer`) - #143248 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143229 - jieyouxu:compiletest-maintenance-1, r=Kobzol [COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary This is part of a patch series to untangle `compiletest` to hopefully nudge it towards being more maintainable. This PR: - Moves some early config checks (some warnings) to the compiletest library. - Moves `src/main.rs` to `src/bin/main.rs` to make the separation (as in, compiletest's library component vs the tool binary component) more obvious. r? ``@Kobzol`` (or reroll)

Rollup of 9 pull requests Successful merges: - rust-lang/rust#143019 (Ensure -V --verbose processes both codegen_backend and codegen-backend) - rust-lang/rust#143140 (give Pointer::into_parts a more scary name and offer a safer alternative) - rust-lang/rust#143175 (Make combining LLD with external LLVM config a hard error) - rust-lang/rust#143180 (Use `tracing-forest` instead of `tracing-tree` for bootstrap tracing) - rust-lang/rust#143223 (Improve macro stats printing) - rust-lang/rust#143228 (Handle build scripts better in `-Zmacro-stats` output.) - rust-lang/rust#143229 ([COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary) - rust-lang/rust#143246 (Subtree update of `rust-analyzer`) - rust-lang/rust#143248 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu added 3 commits June 30, 2025 15:03

Move some early config checks to the compiletest lib

c8cef5b

Move compiletest main.rs to src/bin/

f03074d

To make it obvious `compiletest`-the-tool has two components: 1. The core compiletest library, and 2. The tool binary, which will be executed by bootstrap.

Move RUST_TEST_NOCAPTURE warning to early config check

e664e7e

rustbot assigned Kobzol Jun 30, 2025

jieyouxu mentioned this pull request Jun 30, 2025

[COMPILETEST-UNTANGLE 2/N] Make some compiletest errors/warnings/help more visually obvious #143230

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025

matthiaskrgr mentioned this pull request Jun 30, 2025

Rollup of 5 pull requests #143250

Closed

matthiaskrgr mentioned this pull request Jun 30, 2025

Rollup of 9 pull requests #143254

Merged

bors merged commit 8156725 into rust-lang:master Jul 1, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jul 1, 2025

jieyouxu deleted the compiletest-maintenance-1 branch July 1, 2025 03:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary#143229