`tests/ui/issues/`: The Issues Strike Back [4/N]#144403

Kivooeo · 2025-07-24T13:55:08Z

Some tests/ui/issues/ housekeeping, to trim down number of tests directly under tests/ui/issues/. Part of #133895.

r? @jieyouxu

rustbot · 2025-07-24T13:55:13Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

jieyouxu

Thanks, some nits

tests/ui/closures/unused-closure-warning-16256.rs

tests/ui/coercion/array-slice-coercion-mismatch-15783.rs

tests/ui/drop/early-return-drop-order.rs

tests/ui/drop/vec-replace-skip-while-drop.rs

tests/ui/fn/fn-traits-call-once-signature.rs

tests/ui/statics/conditional-static-declaration.rs

tests/ui/structs/static-struct-init-15043.rs

tests/ui/traits/index-trait-multiple-impls.rs

tests/ui/traits/lifetime-mismatch-trait-impl.rs

tests/ui/statics/conditional-static-declaration.rs

rustbot · 2025-08-09T11:27:32Z

⚠️ Warning ⚠️

This PR is based on an upstream commit that is 16 days old.

It's recommended to update your branch according to the rustc-dev-guide.

Kivooeo · 2025-08-09T12:36:17Z

@rustbot ready

jieyouxu

Thanks

jieyouxu · 2025-08-09T13:02:36Z

@bors r+ rollup

bors · 2025-08-09T13:02:39Z

📌 Commit 1676563 has been approved by jieyouxu

It is now in the queue for this repository.

`tests/ui/issues/`: The Issues Strike Back [4/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? `@jieyouxu`

`tests/ui/issues/`: The Issues Strike Back [4/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? ``@jieyouxu``

`tests/ui/issues/`: The Issues Strike Back [4/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? ```@jieyouxu```

`tests/ui/issues/`: The Issues Strike Back [4/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? ````@jieyouxu````

Rollup of 19 pull requests Successful merges: - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones) - #143093 (Simplify polonius location-sensitive analysis) - #144402 (Stabilize loongarch32 inline asm) - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N]) - #144544 (Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies) - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc) - #145089 (Improve error output when a command fails in bootstrap) - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC) - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC) - #145130 (improve "Documentation problem" issue template.) - #145135 (Stabilize `duration_constructors_lite` feature) - #145145 (some `derive_more` refactors) - #145147 (rename `TraitRef::from_method` to `from_assoc`) - #145156 (Override custom Cargo `build-dir` in bootstrap) - #145160 (Change days-threshold to 28 in [behind-upstream]) - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading) - #145175 (Enable limit_rdylib_exports on Solaris) - #145187 (Fix an unstable feature comment that wasn't a doc comment) - #145191 (`suggest_borrow_generic_arg`: use the correct generic args) r? `@ghost` `@rustbot` modify labels: rollup

`tests/ui/issues/`: The Issues Strike Back [4/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? `````@jieyouxu`````

Rollup of 18 pull requests Successful merges: - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones) - #143093 (Simplify polonius location-sensitive analysis) - #144402 (Stabilize loongarch32 inline asm) - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N]) - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc) - #145089 (Improve error output when a command fails in bootstrap) - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC) - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC) - #145130 (improve "Documentation problem" issue template.) - #145135 (Stabilize `duration_constructors_lite` feature) - #145145 (some `derive_more` refactors) - #145147 (rename `TraitRef::from_method` to `from_assoc`) - #145156 (Override custom Cargo `build-dir` in bootstrap) - #145160 (Change days-threshold to 28 in [behind-upstream]) - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading) - #145175 (Enable limit_rdylib_exports on Solaris) - #145187 (Fix an unstable feature comment that wasn't a doc comment) - #145191 (`suggest_borrow_generic_arg`: use the correct generic args) r? `@ghost` `@rustbot` modify labels: rollup

`tests/ui/issues/`: The Issues Strike Back [4/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? ``````@jieyouxu``````

`tests/ui/issues/`: The Issues Strike Back [4/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? ```````@jieyouxu```````

Rollup of 17 pull requests Successful merges: - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones) - #143093 (Simplify polonius location-sensitive analysis) - #144402 (Stabilize loongarch32 inline asm) - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N]) - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc) - #145089 (Improve error output when a command fails in bootstrap) - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC) - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC) - #145130 (improve "Documentation problem" issue template.) - #145135 (Stabilize `duration_constructors_lite` feature) - #145145 (some `derive_more` refactors) - #145147 (rename `TraitRef::from_method` to `from_assoc`) - #145156 (Override custom Cargo `build-dir` in bootstrap) - #145160 (Change days-threshold to 28 in [behind-upstream]) - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading) - #145187 (Fix an unstable feature comment that wasn't a doc comment) - #145191 (`suggest_borrow_generic_arg`: use the correct generic args) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144403 - Kivooeo:issue4, r=jieyouxu `tests/ui/issues/`: The Issues Strike Back [4/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of #133895. r? ````````@jieyouxu````````

rustbot assigned jieyouxu Jul 24, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the issue4 branch from 972f455 to 897d1f2 Compare July 24, 2025 14:07

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the issue4 branch from 897d1f2 to 07ddcb5 Compare July 24, 2025 14:17

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the issue4 branch from 07ddcb5 to 897d1f2 Compare July 24, 2025 14:35

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the issue4 branch 2 times, most recently from a7c2056 to f7e1327 Compare July 25, 2025 10:33

moved 34 tests to organized locations

90bb5ca

Kivooeo force-pushed the issue4 branch from f7e1327 to 29e78c4 Compare July 25, 2025 10:36

jieyouxu added the S-no-work-capacity-tracking Status: Exempted from triagebot work capacity tracking. label Aug 7, 2025

jieyouxu requested changes Aug 9, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2025

comments

1676563

Kivooeo force-pushed the issue4 branch from 29e78c4 to 1676563 Compare August 9, 2025 11:27

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2025

jieyouxu approved these changes Aug 9, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2025

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 21 pull requests #145192

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 19 pull requests #145195

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 19 pull requests #145197

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 18 pull requests #145204

Closed

Zalathar mentioned this pull request Aug 10, 2025

Rollup of 17 pull requests #145210

Merged

bors merged commit 62b406d into rust-lang:master Aug 10, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 10, 2025

Uh oh!

Conversation

Kivooeo commented Jul 24, 2025

Uh oh!

rustbot commented Jul 24, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Aug 9, 2025

Uh oh!

Kivooeo commented Aug 9, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 9, 2025

Uh oh!

bors commented Aug 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants