Derive `Hash` for rustc_public types#145018

AlexanderPortland · 2025-08-06T19:24:03Z

This derives Hash for the rustc_public versions of Rvalue, Place, Span, and all the types they contain. As far as I can tell, the internal versions of all these types already implement Hash, so it would be helpful if the public versions implemented it too!

rustbot · 2025-08-06T19:24:07Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-08-06T19:24:09Z

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

scottmcm · 2025-08-07T05:48:43Z

compiler/rustc_public/src/ty.rs

 }

-#[derive(Clone, Copy, PartialEq, Eq, Serialize)]
+impl<T: std::hash::Hash> std::hash::Hash for Placeholder<T> {


Why isn't this also derived? If it's deriving Eq and PartialEq, it should almost certainly be deriving Hash too.

Sorry, my bad! I didn't realize the derive macro could handle generics. Just fixed this now

AlexanderPortland · 2025-08-07T16:33:38Z

@rustbot ready

scottmcm · 2025-08-07T18:18:16Z

Sounds good to me; these things that are already derive(PartialEq, Eq) might as well derive(Hash) too.

@bors r+ rollup

bors · 2025-08-07T18:18:18Z

📌 Commit b9e6bd7 has been approved by scottmcm

It is now in the queue for this repository.

…h, r=scottmcm Derive `Hash` for rustc_public types This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!

Rollup of 8 pull requests Successful merges: - #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - #144857 (Port `#[allow_internal_unsafe]` to the new attribute system) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144974 (compiler-builtins subtree update) - #145004 (Couple of minor cleanups) - #145007 (Fix build/doc/test of error index generator) - #145018 (Derive `Hash` for rustc_public types) r? `@ghost` `@rustbot` modify labels: rollup

…h, r=scottmcm Derive `Hash` for rustc_public types This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!

Rollup of 9 pull requests Successful merges: - #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - #144857 (Port `#[allow_internal_unsafe]` to the new attribute system) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144974 (compiler-builtins subtree update) - #145007 (Fix build/doc/test of error index generator) - #145018 (Derive `Hash` for rustc_public types) - #145045 (doc(library): Fix Markdown in `Iterator::by_ref`) - #145046 (Fix doc comment of File::try_lock and File::try_lock_shared) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145018 - AlexanderPortland:rustc-public-hash, r=scottmcm Derive `Hash` for rustc_public types This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!

Rollup of 9 pull requests Successful merges: - rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system) - rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature) - rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`) - rust-lang/rust#144974 (compiler-builtins subtree update) - rust-lang/rust#145007 (Fix build/doc/test of error index generator) - rust-lang/rust#145018 (Derive `Hash` for rustc_public types) - rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`) - rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared) r? `@ghost` `@rustbot` modify labels: rollup

…h, r=scottmcm Derive `Hash` for rustc_public types This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!

Rollup of 9 pull requests Successful merges: - rust-lang#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - rust-lang#144857 (Port `#[allow_internal_unsafe]` to the new attribute system) - rust-lang#144900 (Stabilize `unsigned_signed_diff` feature) - rust-lang#144903 (Rename `begin_panic_handler` to `panic_handler`) - rust-lang#144974 (compiler-builtins subtree update) - rust-lang#145007 (Fix build/doc/test of error index generator) - rust-lang#145018 (Derive `Hash` for rustc_public types) - rust-lang#145045 (doc(library): Fix Markdown in `Iterator::by_ref`) - rust-lang#145046 (Fix doc comment of File::try_lock and File::try_lock_shared) r? `@ghost` `@rustbot` modify labels: rollup

…h, r=scottmcm Derive `Hash` for rustc_public types This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!

Rollup of 9 pull requests Successful merges: - rust-lang#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - rust-lang#144857 (Port `#[allow_internal_unsafe]` to the new attribute system) - rust-lang#144900 (Stabilize `unsigned_signed_diff` feature) - rust-lang#144903 (Rename `begin_panic_handler` to `panic_handler`) - rust-lang#144974 (compiler-builtins subtree update) - rust-lang#145007 (Fix build/doc/test of error index generator) - rust-lang#145018 (Derive `Hash` for rustc_public types) - rust-lang#145045 (doc(library): Fix Markdown in `Iterator::by_ref`) - rust-lang#145046 (Fix doc comment of File::try_lock and File::try_lock_shared) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system) - rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature) - rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`) - rust-lang/rust#144974 (compiler-builtins subtree update) - rust-lang/rust#145007 (Fix build/doc/test of error index generator) - rust-lang/rust#145018 (Derive `Hash` for rustc_public types) - rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`) - rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared) r? `@ghost` `@rustbot` modify labels: rollup

make rustc_public types derive Hash

56d5aab

rustbot assigned scottmcm Aug 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2025

AlexanderPortland mentioned this pull request Aug 6, 2025

Cache codegen of Spans model-checking/kani#4277

Closed

scottmcm reviewed Aug 7, 2025

View reviewed changes

scottmcm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2025

derive hash for placeholder automatically

b9e6bd7

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2025

tgross35 mentioned this pull request Aug 7, 2025

Rollup of 8 pull requests #145063

Closed

tgross35 mentioned this pull request Aug 7, 2025

Rollup of 9 pull requests #145072

Closed

tgross35 mentioned this pull request Aug 8, 2025

Rollup of 9 pull requests #145074

Merged

bors merged commit 41b6da1 into rust-lang:master Aug 8, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Derive `Hash` for rustc_public types#145018