Skip to content

Add some conversion trait impls #145504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jules-Bertholet wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add some conversion trait impls #145504

Jules-Bertholet wants to merge 2 commits into from
+75 −1

Conversation

@Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Aug 16, 2025 •
edited by joshtriplett
Loading

@rustbot label T-libs-api needs-fcp -T-libs

I’ve tried to only add impls that are unlikely to cause single-applicable-impl inference breakage.

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 16, 2025
@Jules-Bertholet Jules-Bertholet mentioned this pull request Aug 16, 2025
Open
7 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet Jules-Bertholet force-pushed the more_conversion_trait_impls branch from 7ef29d9 to 3a96604 Compare August 16, 2025 17:22
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet Jules-Bertholet force-pushed the more_conversion_trait_impls branch 2 times, most recently from 676ff1f to bd960c9 Compare August 16, 2025 18:13
@jieyouxu
Copy link
Member

jieyouxu commented Aug 17, 2025

r? libs-api

@rustbot rustbot assigned m-ou-se and unassigned Mark-Simulacrum Aug 17, 2025
clarfonthey
clarfonthey reviewed Aug 17, 2025
View reviewed changes
clarfonthey
clarfonthey reviewed Aug 17, 2025
View reviewed changes
@tgross35
Copy link
Contributor

tgross35 commented Sep 5, 2025 •
edited
Loading

Preparing for crater

@bors try

@rustbot label +I-libs-api-nominated
r? libs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 5, 2025
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 5, 2025
@rust-bors
Auto merge of #145504 - Jules-Bertholet:more_conversion_trait_impls, …
0498c15 
…r=<try>

Add some conversion trait impls
@rustbot rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 5, 2025
tgross35
tgross35 reviewed Sep 5, 2025
View reviewed changes
library/core/src/ascii/ascii_char.rs Outdated
Comment on lines 1181 to 1191
impl AsMut<str> for AsciiChar {
#[inline(always)]
fn as_mut(&mut self) -> &mut str {
let ascii_ptr: *mut [Self] = crate::slice::from_mut(self);
let str_ptr = ascii_ptr as *mut str;
// SAFETY: Each ASCII codepoint in UTF-8 is encoded as one single-byte
// code unit having the same value as the ASCII byte.
unsafe { &mut *str_ptr }
}
}
Copy link
Contributor

@tgross35 tgross35 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be implemented in a new as_mut_str method, similar to as_str

Also, could everything here use #[inline] without the always?

@tgross35 tgross35 added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2025
@rust-bors
Copy link
Contributor

rust-bors bot commented Sep 5, 2025

☀️ Try build successful (CI)
Build commit: 0498c15 (0498c157964e0946754e29e57ee9ef4527dc2a42, parent: af00ff2ce62b6617ed19305ae39e135ac71d0b22)

@tgross35
Copy link
Contributor

tgross35 commented Sep 5, 2025

@craterbot check

@the8472
Copy link
Member

the8472 commented Oct 21, 2025

@rfcbot merge

@rust-rfcbot

This comment was marked as outdated.

Sign in to view
@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 21, 2025
@the8472 the8472 removed the S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api label Oct 21, 2025
@tgross35

This comment was marked as resolved.

Sign in to view
@the8472

This comment was marked as resolved.

Sign in to view
@rust-rfcbot

This comment was marked as resolved.

Sign in to view
@rust-rfcbot rust-rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 21, 2025
@the8472 the8472 removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 21, 2025
@the8472

This comment was marked as resolved.

Sign in to view
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Oct 21, 2025 •
edited by dtolnay
Loading

Team member @the8472 has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 21, 2025
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Oct 27, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@SUPERCILEX
Copy link
Contributor

SUPERCILEX commented Oct 30, 2025

Can we get rid of my transpose function in favor of the from impl? Seems a bit weird to have both.

@clarfonthey
Copy link
Contributor

clarfonthey commented Oct 31, 2025

I think that dedicated methods are nice because they make things a little clearer than just into(). We're allowed to have both.

@SUPERCILEX
Copy link
Contributor

SUPERCILEX commented Oct 31, 2025

Fair enough

@rust-rfcbot rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Nov 6, 2025
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Nov 6, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot rustbot mentioned this pull request Nov 6, 2025
Open
tgross35
tgross35 requested changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, these could be #[inline] and not #inline(always)]. That and a squash then r=me

View changes since this review

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 6, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 29, 2026
@tgross35
Copy link
Contributor

tgross35 commented Jan 30, 2026

@Jules-Bertholet gentle ping for the small request above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 requested changes

+1 more reviewer

@clarfonthey clarfonthey clarfonthey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tgross35 tgross35

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.