Skip to content

Rehome 26 tests/ui/issues/ tests to other subdirectories under tests/ui/ [#5 of Batch #2]#146490

Merged
bors merged 1 commit intorust-lang:masterfrom
Oneirical:uncountable-integer-12
Oct 19, 2025
Merged

Rehome 26 tests/ui/issues/ tests to other subdirectories under tests/ui/ [#5 of Batch #2]#146490
bors merged 1 commit intorust-lang:masterfrom
Oneirical:uncountable-integer-12

Conversation

@Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Sep 12, 2025

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

Inspired by the methodology that Kivooeo was using.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 12, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Sep 13, 2025 

error: aux-build `/checkout/tests/ui/issues/auxiliary/reexported-trait.rs` source not found

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Oneirical Oneirical force-pushed the uncountable-integer-12 branch from 8ae4b39 to 7d6d136 Compare October 1, 2025 03:38
@jieyouxu jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2025
jieyouxu
jieyouxu requested changes Oct 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few nits

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025
@Oneirical Oneirical force-pushed the uncountable-integer-12 branch from 7d6d136 to d28c7f4 Compare October 12, 2025 02:12
@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2025

⚠️ Warning ⚠️

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer-12 branch from d28c7f4 to 9a73fa6 Compare October 12, 2025 03:01
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer-12 branch from 9a73fa6 to 926599a Compare October 12, 2025 04:33
@Oneirical
Copy link
Contributor Author

Oneirical commented Oct 12, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 12, 2025
jieyouxu
jieyouxu approved these changes Oct 18, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Oct 18, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 18, 2025

📌 Commit 926599a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#146490 - Oneirical:uncountable-integer-12, …
8f9e2b7 
…r=jieyouxu

Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [rust-lang#5 of Batch rust-lang#2]

Part of rust-lang#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that Kivooeo was using.

r? `@jieyouxu`
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2025
Closed
bors added a commit that referenced this pull request Oct 18, 2025
@bors
Auto merge of #147856 - matthiaskrgr:rollup-ksxc78w, r=matthiaskrgr
ec669eb 
Rollup of 8 pull requests

Successful merges:

 - #138679 (Issue-125323: ICE non-ADT in struct pattern when long time constant evaluation is in for loop)
 - #146167 (Deny-by-default never type lints)
 - #146490 (Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2])
 - #147438 (Rename "non-inline module" to "file module" in proc macro diagnostics)
 - #147724 (Fix ICE in pattern matching with generic const array length errors)
 - #147813 (Warn on unused_attributes in uitests )
 - #147816 (Do not error out for `download-rustc` if LTO is configured)
 - #147845 (Add regression test for 134355)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#146490 - Oneirical:uncountable-integer-12, …
ae3c4ea 
…r=jieyouxu

Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [rust-lang#5 of Batch rust-lang#2]

Part of rust-lang#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that Kivooeo was using.

r? ``@jieyouxu``
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2025
Merged
bors added a commit that referenced this pull request Oct 19, 2025
@bors
Auto merge of #147863 - matthiaskrgr:rollup-l4alyf0, r=matthiaskrgr
377a931 
Rollup of 7 pull requests

Successful merges:

 - #138679 (Issue-125323: ICE non-ADT in struct pattern when long time constant evaluation is in for loop)
 - #146490 (Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2])
 - #147438 (Rename "non-inline module" to "file module" in proc macro diagnostics)
 - #147724 (Fix ICE in pattern matching with generic const array length errors)
 - #147813 (Warn on unused_attributes in uitests )
 - #147816 (Do not error out for `download-rustc` if LTO is configured)
 - #147845 (Add regression test for 134355)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5559313 into rust-lang:master Oct 19, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 19, 2025
rust-timer added a commit that referenced this pull request Oct 19, 2025
@rust-timer
Unrolled build for #146490
de1406e 
Rollup merge of #146490 - Oneirical:uncountable-integer-12, r=jieyouxu

Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2]

Part of #133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that Kivooeo was using.

r? ```@jieyouxu```
@reddevilmidzy reddevilmidzy mentioned this pull request Dec 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Oneirical @rustbot @rust-log-analyzer @jieyouxu @bors