include outer_inclusive_binder of pattern types#147226
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 1, 2025
Merged
include outer_inclusive_binder of pattern types#147226bors merged 2 commits intorust-lang:masterfrom
outer_inclusive_binder of pattern types#147226bors merged 2 commits intorust-lang:masterfrom
Conversation
jdonszelmann
commented
Oct 1, 2025
|
|
||
| fn add_ty_pat(&mut self, pat: <I as Interner>::Pat) { | ||
| self.add_flags(pat.flags()); | ||
| self.add_exclusive_binder(pat.outer_exclusive_binder()); |
Contributor
Author
There was a problem hiding this comment.
this is the one line that actually fixes the issue. We didn't record the fact that pattern types might have bound variables inside them without this
Contributor
Author
There was a problem hiding this comment.
without it, this:
rust/compiler/rustc_middle/src/ty/pattern.rs
Lines 36 to 49 in 1e1a394
is actually dead code
Contributor
|
@bors r+ rollup there's also a theoretical unsoundness fixed by this change where anonymize bound vars doesn't result in different bound vars, so we get different gj gamer |
Collaborator
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 1, 2025
…lver, r=lcnr include `outer_inclusive_binder` of pattern types Fixes rust-lang/trait-system-refactor-initiative#237 r? `@lcnr`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 1, 2025
…lver, r=lcnr include `outer_inclusive_binder` of pattern types Fixes rust-lang/trait-system-refactor-initiative#237 r? ``@lcnr``
This was referenced Oct 1, 2025
bors
added a commit
that referenced
this pull request
Oct 1, 2025
Rollup of 8 pull requests Successful merges: - #146593 (Allow specifying multiple bounds for same associated item, except in trait objects) - #147177 ([DebugInfo] Fix MSVC tuple child creation) - #147195 (iter repeat: add tests for new count and last behavior) - #147202 (Swap order of `resolve_coroutine_interiors` and `handle_opaque_type_uses`) - #147204 (Refactor ArrayWindows to use a slice) - #147219 (Add proper error handling for closure in impl) - #147226 (include `outer_inclusive_binder` of pattern types) - #147230 (Fix typo in 'unfulfilled_lint_expectation' to plural) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 1, 2025
Rollup merge of #147226 - jdonszelmann:pattern-types-next-solver, r=lcnr include `outer_inclusive_binder` of pattern types Fixes rust-lang/trait-system-refactor-initiative#237 r? ```@lcnr```
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Oct 9, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#146593 (Allow specifying multiple bounds for same associated item, except in trait objects) - rust-lang#147177 ([DebugInfo] Fix MSVC tuple child creation) - rust-lang#147195 (iter repeat: add tests for new count and last behavior) - rust-lang#147202 (Swap order of `resolve_coroutine_interiors` and `handle_opaque_type_uses`) - rust-lang#147204 (Refactor ArrayWindows to use a slice) - rust-lang#147219 (Add proper error handling for closure in impl) - rust-lang#147226 (include `outer_inclusive_binder` of pattern types) - rust-lang#147230 (Fix typo in 'unfulfilled_lint_expectation' to plural) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/trait-system-refactor-initiative#237
r? @lcnr