Disable triagebot auto stable-regression compiler backport nominations pending redesign#147263
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 3, 2025
Merged
Conversation
Collaborator
|
|
rustbot
added
A-meta
apiraino
approved these changes
Oct 2, 2025
No prejudice against re-enabling them if the nominations include a bit more context on _why_ it's automatically nominated and _which_ regression(s) are being addressed. Or as proposed, it could also simply become a reminder-to-nominate _comment_.
jieyouxu
force-pushed
the
disable-auto-backport-nominations
branch
from
f7f9846 to
16cfde9
Compare
jieyouxu
changed the title
Member
Author
|
Modified to only disable the stable auto backport nominations, since stable backports have a substantially higher bar, which makes those very prone to false positives. |
Member
Author
|
(Also this is r-l/r so you'll need to bors 😁) |
Urgau
approved these changes
Oct 2, 2025
Member
|
@bors r=apiraino,Urgau |
Collaborator
bors
added
S-waiting-on-bors
Member
|
@bors rollup |
bors
added a commit
that referenced
this pull request
Oct 3, 2025
Rollup of 6 pull requests Successful merges: - #141839 (make rust-analyzer use a dedicated build directory) - #146166 (Implement range support in `//@ edition`) - #147259 (cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2`) - #147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign) - #147268 (add arm-maintainers to various targets) - #147270 (Move doc_cfg-specific code into `cfg.rs`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 3, 2025
Rollup merge of #147263 - jieyouxu:disable-auto-backport-nominations, r=apiraino,Urgau Disable triagebot auto stable-regression compiler backport nominations pending redesign Current auto compiler stable-regression backport nominations seem to be too aggressive, and seems to unfortunately lower signal-to-noise ratio of the compiler backport channel. So this PR disables the triagebot compiler auto stable-regression backport nominations pending a redesign. Beta-regression auto backport nominations are not modified, we might want to gather some more experience with it. No prejudice against re-enabling them if the nominations include a bit more context on _why_ it's automatically nominated and _which_ regression(s) are being addressed. Or as proposed, it could also simply become a reminder-to-nominate _comment_. cf. [#t-compiler/backports > #146919: stable-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23146919.3A.20stable-nominated/near/540979327) > I like the idea of rustbot just posting a message that suggests adding the label. That seems like a good compromise between avoiding forgotten nominations and avoiding spurious nominations. In any case, this was very much worth experimenting! r? `@apiraino` (or triagebot)
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Oct 6, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#141839 (make rust-analyzer use a dedicated build directory) - rust-lang/rust#146166 (Implement range support in `//@ edition`) - rust-lang/rust#147259 (cg_llvm: Use helper methods for all calls to `LLVMMDNodeInContext2`) - rust-lang/rust#147263 (Disable triagebot auto stable-regression compiler backport nominations pending redesign) - rust-lang/rust#147268 (add arm-maintainers to various targets) - rust-lang/rust#147270 (Move doc_cfg-specific code into `cfg.rs`) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 15, 2025
…, r=Kobzol Update t-compiler beta nomination Zulip msg Sister patch of [triagebot#2191](rust-lang/triagebot#2191) Follow-up to rust-lang#147263 The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take. The wording (as per [triagebot#2191](rust-lang/triagebot#2191)) is open to suggestions. Thanks
rust-timer
added a commit
that referenced
this pull request
Oct 16, 2025
Rollup merge of #147527 - apiraino:update-beta-nom-zulip-msg, r=Kobzol Update t-compiler beta nomination Zulip msg Sister patch of [triagebot#2191](rust-lang/triagebot#2191) Follow-up to #147263 The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take. The wording (as per [triagebot#2191](rust-lang/triagebot#2191)) is open to suggestions. Thanks
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 16, 2025
Update t-compiler beta nomination Zulip msg Sister patch of [triagebot#2191](rust-lang/triagebot#2191) Follow-up to rust-lang/rust#147263 The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take. The wording (as per [triagebot#2191](rust-lang/triagebot#2191)) is open to suggestions. Thanks
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Oct 18, 2025
Update t-compiler beta nomination Zulip msg Sister patch of [triagebot#2191](rust-lang/triagebot#2191) Follow-up to rust-lang/rust#147263 The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take. The wording (as per [triagebot#2191](rust-lang/triagebot#2191)) is open to suggestions. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current auto compiler stable-regression backport nominations seem to be too aggressive, and seems to unfortunately lower signal-to-noise ratio of the compiler backport channel. So this PR disables the triagebot compiler auto stable-regression backport nominations pending a redesign. Beta-regression auto backport nominations are not modified, we might want to gather some more experience with it.
No prejudice against re-enabling them if the nominations include a bit more context on why it's automatically nominated and which regression(s) are being addressed. Or as proposed, it could also simply become a reminder-to-nominate comment.
cf. #t-compiler/backports > #146919: stable-nominated @ 💬
In any case, this was very much worth experimenting!
r? @apiraino (or triagebot)