Skip to content

Avoid to suggest pattern match on the similarly named in fn signature#147320

Merged
bors merged 1 commit intorust-lang:masterfrom
chenyukang:yukang-fix-147303-fn-arg
Oct 5, 2025
Merged

Avoid to suggest pattern match on the similarly named in fn signature#147320
bors merged 1 commit intorust-lang:masterfrom
chenyukang:yukang-fix-147303-fn-arg

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 4, 2025 •
edited by rustbot
Loading

Fixes #147303

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@chenyukang chenyukang mentioned this pull request Oct 4, 2025
Merged
jieyouxu
jieyouxu approved these changes Oct 4, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me with two test nits

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Oct 4, 2025

r? jieyouxu @rustbot author

@rustbot rustbot assigned jieyouxu and unassigned nnethercote Oct 4, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025
@chenyukang chenyukang force-pushed the yukang-fix-147303-fn-arg branch from c4e96ff to 958d9bb Compare October 4, 2025 07:27
@chenyukang
Copy link
Member Author

chenyukang commented Oct 4, 2025

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Oct 4, 2025

📌 Commit 958d9bb has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 4, 2025
@Zalathar
Rollup merge of rust-lang#147320 - chenyukang:yukang-fix-147303-fn-ar…
636a744 
…g, r=jieyouxu

Avoid to suggest pattern match on the similarly named in fn signature

Fixes rust-lang#147303
@Zalathar Zalathar mentioned this pull request Oct 4, 2025
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Oct 4, 2025

I should've waited for PR CI, lol.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2025
@chenyukang chenyukang force-pushed the yukang-fix-147303-fn-arg branch from 958d9bb to e9a45e6 Compare October 4, 2025 09:13
@chenyukang
Copy link
Member Author

chenyukang commented Oct 4, 2025

Fixed the test case: https://github.com/rust-lang/rust/compare/958d9bb4fe980c550bcf259e3ffe811518660fa7..e9a45e66461f3c324a249d7352eb2f4d184a6b2a

@chenyukang
Copy link
Member Author

chenyukang commented Oct 4, 2025

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Oct 4, 2025

📌 Commit e9a45e6 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147320 - chenyukang:yukang-fix-147303-fn-ar…
91c4d7e 
…g, r=jieyouxu

Avoid to suggest pattern match on the similarly named in fn signature

Fixes rust-lang#147303
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147320 - chenyukang:yukang-fix-147303-fn-ar…
12f8194 
…g, r=jieyouxu

Avoid to suggest pattern match on the similarly named in fn signature

Fixes rust-lang#147303
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147320 - chenyukang:yukang-fix-147303-fn-ar…
a3355a0 
…g, r=jieyouxu

Avoid to suggest pattern match on the similarly named in fn signature

Fixes rust-lang#147303
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147320 - chenyukang:yukang-fix-147303-fn-ar…
9259b14 
…g, r=jieyouxu

Avoid to suggest pattern match on the similarly named in fn signature

Fixes rust-lang#147303
@Zalathar Zalathar mentioned this pull request Oct 5, 2025
Closed
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of #147359 - Zalathar:rollup-x1pnbjz, r=Zalathar
24bca67 
Rollup of 8 pull requests

Successful merges:

 - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition)
 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147309 (Add documentation about unwinding to wasm targets)
 - #147310 (Mark `PatternTypo` suggestion as maybe incorrect)
 - #147320 (Avoid to suggest pattern match on the similarly named in fn signature)
 - #147328 (Implement non-poisoning `Mutex::with_mut`, `RwLock::with` and `RwLock::with_mut`)
 - #147337 (Make `fmt::Write` a diagnostic item)
 - #147349 (Improve the advice given by panic_immediate_abort)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar Zalathar mentioned this pull request Oct 5, 2025
Merged
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of #147363 - Zalathar:rollup-d9kd06g, r=Zalathar
e2c96cc 
Rollup of 7 pull requests

Successful merges:

 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147309 (Add documentation about unwinding to wasm targets)
 - #147310 (Mark `PatternTypo` suggestion as maybe incorrect)
 - #147320 (Avoid to suggest pattern match on the similarly named in fn signature)
 - #147328 (Implement non-poisoning `Mutex::with_mut`, `RwLock::with` and `RwLock::with_mut`)
 - #147337 (Make `fmt::Write` a diagnostic item)
 - #147349 (Improve the advice given by panic_immediate_abort)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cae84c6 into rust-lang:master Oct 5, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 5, 2025
rust-timer added a commit that referenced this pull request Oct 5, 2025
@rust-timer
Unrolled build for #147320
b621d3f 
Rollup merge of #147320 - chenyukang:yukang-fix-147303-fn-arg, r=jieyouxu

Avoid to suggest pattern match on the similarly named in fn signature

Fixes #147303
@fmease fmease mentioned this pull request Oct 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercote nnethercote nnethercote approved these changes

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

Wrong suggestion for unused_variables accepted by cargo fix

6 participants

@chenyukang @rustbot @jieyouxu @bors @rust-log-analyzer @nnethercote