Conversation
This comment has been minimized.
This comment has been minimized.
|
now you need to fix the mess that has happened in the meantime :D |
|
Haha, I just realized that, ok, give me some time I will fix everything |
|
Unironically, but |
42c12fc to
5c79424
Compare
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_codegen_ssa |
|
Ok maybe not everything |
This comment has been minimized.
This comment has been minimized.
5c79424 to
67bc030
Compare
|
Now it should be fine |
|
Thanks! @bors r+ rollup |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing bcbbdcb (parent) -> 981353c (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 981353ca16018bb35e232684b5f91f0943bf45bf --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (981353c): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.8%, secondary 2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 472.313s -> 471.402s (-0.19%) |
…ments, r=kobzol Fluent tidy improvements Follow-up of rust-lang#147345 and of rust-lang#147191. It uses `fluent_syntax` to parse `fluent` files (but not for blessing, not even sure how the current one works). I also added an `assert` to ensure we never go to previous situation where the `fluent` files were actually not checked at all. cc `@Kivooeo` r? kobzol
…ments, r=kobzol Fluent tidy improvements Follow-up of rust-lang#147345 and of rust-lang#147191. It uses `fluent_syntax` to parse `fluent` files (but not for blessing, not even sure how the current one works). I also added an `assert` to ensure we never go to previous situation where the `fluent` files were actually not checked at all. cc ``@Kivooeo`` r? kobzol
Rollup merge of #147396 - GuillaumeGomez:fluent-tidy-improvements, r=kobzol Fluent tidy improvements Follow-up of #147345 and of #147191. It uses `fluent_syntax` to parse `fluent` files (but not for blessing, not even sure how the current one works). I also added an `assert` to ensure we never go to previous situation where the `fluent` files were actually not checked at all. cc ``@Kivooeo`` r? kobzol
…kobzol Fluent tidy improvements Follow-up of rust-lang/rust#147345 and of rust-lang/rust#147191. It uses `fluent_syntax` to parse `fluent` files (but not for blessing, not even sure how the current one works). I also added an `assert` to ensure we never go to previous situation where the `fluent` files were actually not checked at all. cc ``@Kivooeo`` r? kobzol
…kobzol Fluent tidy improvements Follow-up of rust-lang/rust#147345 and of rust-lang/rust#147191. It uses `fluent_syntax` to parse `fluent` files (but not for blessing, not even sure how the current one works). I also added an `assert` to ensure we never go to previous situation where the `fluent` files were actually not checked at all. cc ``@Kivooeo`` r? kobzol
As was explained here #147191 (comment), this reverting this change because
fltis incorrect formatAlso maybe there is existed PR for that? I didn't found one
Follow up #147191
cc @GuillaumeGomez