Use globals instead of metadata for std::autodiff#147390

ZuseZ4 · 2025-10-06T02:48:42Z

LLVM's Metadata is quite fragile. In debug builds we use incremental compilation, which caused the metadata to be dropped. With this change we use named globals instead of metadata to instruct Enzyme how to differentiate functions.
Globals are proper llvm values and thus can't be dropped. Also added an incremental/dbg test which now passes, to unblock the EnzymeAD CI which wants to run Rust autodiff tests.

r? compiler

rustbot · 2025-10-06T02:48:46Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ZuseZ4 · 2025-10-06T03:03:14Z

r? @jieyouxu since you already reviewed my last two test PRs I might as well directly assign you ^^ Thanks! (and please reroll if you're too busy!)

rustbot · 2025-10-06T03:03:19Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

jieyouxu

One comment nit

View changes since this review

tests/ui/autodiff/incremental.rs

jieyouxu

Thanks

View changes since this review

jieyouxu · 2025-10-07T07:27:16Z

You can r=me once tidy is green

ZuseZ4 · 2025-10-07T08:48:53Z

@bors r=jieyouxu rollup

bors · 2025-10-07T08:48:55Z

📌 Commit 6ce845a has been approved by jieyouxu

It is now in the queue for this repository.

Use globals instead of metadata for std::autodiff LLVM's Metadata is quite fragile. In debug builds we use incremental compilation, which caused the metadata to be dropped. With this change we use named globals instead of metadata to instruct Enzyme how to differentiate functions. Globals are proper llvm values and thus can't be dropped. Also added an incremental/dbg test which now passes, to unblock the EnzymeAD CI which wants to run Rust autodiff tests. r? compiler

Rollup of 7 pull requests Successful merges: - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #145608 (Prevent downstream `impl DerefMut for Pin<LocalType>`) - #146865 (kcfi: only reify trait methods when dyn-compatible) - #147390 (Use globals instead of metadata for std::autodiff) - #147398 (Fix; correct placement of type inference error for method calls) - #147431 (compiletest: Read the whole test file before parsing directives) - #147433 (Fix doc comment) r? `@ghost` `@rustbot` modify labels: rollup

Use globals instead of metadata for std::autodiff LLVM's Metadata is quite fragile. In debug builds we use incremental compilation, which caused the metadata to be dropped. With this change we use named globals instead of metadata to instruct Enzyme how to differentiate functions. Globals are proper llvm values and thus can't be dropped. Also added an incremental/dbg test which now passes, to unblock the EnzymeAD CI which wants to run Rust autodiff tests. r? compiler

Rollup of 8 pull requests Successful merges: - #145608 (Prevent downstream `impl DerefMut for Pin<LocalType>`) - #146865 (kcfi: only reify trait methods when dyn-compatible) - #147205 (Add a new `wasm32-wasip3` target to Rust) - #147390 (Use globals instead of metadata for std::autodiff) - #147398 (Fix; correct placement of type inference error for method calls) - #147422 (collect-license-metadata: Print a diff of the expected output) - #147431 (compiletest: Read the whole test file before parsing directives) - #147433 (Fix doc comment) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #146865 (kcfi: only reify trait methods when dyn-compatible) - #147205 (Add a new `wasm32-wasip3` target to Rust) - #147322 (cg_llvm: Consistently import `llvm::Type` and `llvm::Value`) - #147398 (Fix; correct placement of type inference error for method calls) - #147410 (Update `S-waiting-on-team` refs to new `S-waiting-on-{team}` labels) - #147422 (collect-license-metadata: Print a diff of the expected output) - #147431 (compiletest: Read the whole test file before parsing directives) - #147433 (Fix doc comment) Failed merges: - #147390 (Use globals instead of metadata for std::autodiff) r? `@ghost` `@rustbot` modify labels: rollup

rustbot · 2025-10-08T00:02:16Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

…g builds

ZuseZ4 · 2025-10-08T01:19:36Z

@bors r=jieyouxu

bors · 2025-10-08T01:19:39Z

📌 Commit 218fa60 has been approved by jieyouxu

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #146385 (rustdoc-search: redesign throbber to be less distracting) - #147390 (Use globals instead of metadata for std::autodiff) - #147445 (sort attribute targets for more consistent error messages) - #147448 (collect-license-metadata: update submodules before running) - #147451 (fix panic with extra-const-ub-checks) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147390 - ZuseZ4:autodiff-dbg, r=jieyouxu Use globals instead of metadata for std::autodiff LLVM's Metadata is quite fragile. In debug builds we use incremental compilation, which caused the metadata to be dropped. With this change we use named globals instead of metadata to instruct Enzyme how to differentiate functions. Globals are proper llvm values and thus can't be dropped. Also added an incremental/dbg test which now passes, to unblock the EnzymeAD CI which wants to run Rust autodiff tests. r? compiler

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#146865 (kcfi: only reify trait methods when dyn-compatible) - rust-lang#147205 (Add a new `wasm32-wasip3` target to Rust) - rust-lang#147322 (cg_llvm: Consistently import `llvm::Type` and `llvm::Value`) - rust-lang#147398 (Fix; correct placement of type inference error for method calls) - rust-lang#147410 (Update `S-waiting-on-team` refs to new `S-waiting-on-{team}` labels) - rust-lang#147422 (collect-license-metadata: Print a diff of the expected output) - rust-lang#147431 (compiletest: Read the whole test file before parsing directives) - rust-lang#147433 (Fix doc comment) Failed merges: - rust-lang#147390 (Use globals instead of metadata for std::autodiff) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned nnethercote Oct 6, 2025

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Oct 6, 2025

rustbot added F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 6, 2025

rustbot assigned fmease and unassigned nnethercote Oct 6, 2025

rustbot assigned jieyouxu and unassigned fmease Oct 6, 2025

ZuseZ4 mentioned this pull request Oct 6, 2025

ci: add a github action ci to test Rust std::autodiff EnzymeAD/Enzyme#2430

Merged

jieyouxu reviewed Oct 7, 2025

View reviewed changes

tests/ui/autodiff/incremental.rs Show resolved Hide resolved

ZuseZ4 force-pushed the autodiff-dbg branch from af75871 to 6ce845a Compare October 7, 2025 07:23

jieyouxu approved these changes Oct 7, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2025

Zalathar mentioned this pull request Oct 7, 2025

Rollup of 7 pull requests #147435

Closed

Zalathar mentioned this pull request Oct 7, 2025

Rollup of 8 pull requests #147440

Closed

matthiaskrgr mentioned this pull request Oct 7, 2025

Rollup of 8 pull requests #147453

Merged

ZuseZ4 force-pushed the autodiff-dbg branch 2 times, most recently from 3e5fb1f to 1f3517b Compare October 8, 2025 00:02

This comment has been minimized.

Sign in to view

ZuseZ4 added 3 commits October 7, 2025 20:13

add incremental/debug test for autodiff

dcc36a8

Use globals instead of metadata, since metadata isn't emitted in debu…

52e7917

…g builds

update ui test since the new frontend is a bit more lenient

218fa60

ZuseZ4 force-pushed the autodiff-dbg branch from 1f3517b to 218fa60 Compare October 8, 2025 00:14

jdonszelmann mentioned this pull request Oct 8, 2025

Rollup of 5 pull requests #147466

Merged

bors merged commit 27b3881 into rust-lang:master Oct 8, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Oct 8, 2025

ZuseZ4 deleted the autodiff-dbg branch January 31, 2026 05:39

Uh oh!

Conversation

ZuseZ4 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 6, 2025

Uh oh!

ZuseZ4 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 6, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Oct 7, 2025

Uh oh!

ZuseZ4 commented Oct 7, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

rustbot commented Oct 8, 2025

Uh oh!

This comment has been minimized.

ZuseZ4 commented Oct 8, 2025

Uh oh!

bors commented Oct 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ZuseZ4 commented Oct 6, 2025 •

edited

Loading

ZuseZ4 commented Oct 6, 2025 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading