Skip to content

const Cell methods#147788

Merged
bors merged 2 commits intorust-lang:masterfrom
clarfonthey:const-cell
Oct 22, 2025
Merged

const Cell methods#147788
bors merged 2 commits intorust-lang:masterfrom
clarfonthey:const-cell

Conversation

@clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Oct 16, 2025 •
edited by rustbot
Loading

Tracking: #147787

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2025

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

@clarfonthey clarfonthey mentioned this pull request Oct 16, 2025
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clarfonthey clarfonthey mentioned this pull request Oct 19, 2025
Open
3 tasks
oli-obk
oli-obk reviewed Oct 19, 2025
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Oct 19, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 19, 2025

📌 Commit a3495e5 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 19, 2025
@Zalathar
Rollup merge of rust-lang#147788 - clarfonthey:const-cell, r=oli-obk
09eef13 
const Cell methods

Tracking: rust-lang#147787

r? `@oli-obk`
@Zalathar Zalathar mentioned this pull request Oct 19, 2025
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Oct 19, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2025
@clarfonthey
Copy link
Contributor Author

clarfonthey commented Oct 21, 2025

Sorry, I shouldn't have assumed that just moving the method would work, since there ended up being unused imports. It's fixed now.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 21, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 21, 2025

📌 Commit 31a2c56 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 22, 2025
Merged
bors added a commit that referenced this pull request Oct 22, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
b2ee1b3 
Rollup of 7 pull requests

Successful merges:

 - #141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - #142339 (Add NonNull pattern types)
 - #147768 (Code refactoring on hir report_no_match_method_error)
 - #147788 (const Cell methods)
 - #147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - #147933 (os_str: Make platform docs more consistent)
 - #147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8c40b9c into rust-lang:master Oct 22, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 22, 2025
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 23, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
698b2f9 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang/rust#142339 (Add NonNull pattern types)
 - rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang/rust#147788 (const Cell methods)
 - rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang/rust#147933 (os_str: Make platform docs more consistent)
 - rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 27, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
51930ee 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang/rust#142339 (Add NonNull pattern types)
 - rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang/rust#147788 (const Cell methods)
 - rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang/rust#147933 (os_str: Make platform docs more consistent)
 - rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 4, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
80008e8 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang/rust#142339 (Add NonNull pattern types)
 - rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang/rust#147788 (const Cell methods)
 - rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang/rust#147933 (os_str: Make platform docs more consistent)
 - rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@matthiaskrgr
Rollup merge of rust-lang#147788 - clarfonthey:const-cell, r=oli-obk
c350666 
const Cell methods

Tracking: rust-lang#147787

r? `@oli-obk`
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge of rust-lang#147957 - matthiaskrgr:rollup-aqt593u, r=matth…
1486d5e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang#142339 (Add NonNull pattern types)
 - rust-lang#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang#147788 (const Cell methods)
 - rust-lang#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang#147933 (os_str: Make platform docs more consistent)
 - rust-lang#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@matthiaskrgr
Rollup merge of rust-lang#147788 - clarfonthey:const-cell, r=oli-obk
bfb837e 
const Cell methods

Tracking: rust-lang#147787

r? `@oli-obk`
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge of rust-lang#147957 - matthiaskrgr:rollup-aqt593u, r=matth…
42b6509 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang#142339 (Add NonNull pattern types)
 - rust-lang#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang#147788 (const Cell methods)
 - rust-lang#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang#147933 (os_str: Make platform docs more consistent)
 - rust-lang#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
8cd7c95 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang/rust#142339 (Add NonNull pattern types)
 - rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang/rust#147788 (const Cell methods)
 - rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang/rust#147933 (os_str: Make platform docs more consistent)
 - rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@matthiaskrgr
Rollup merge of rust-lang#147788 - clarfonthey:const-cell, r=oli-obk
eaf5c82 
const Cell methods

Tracking: rust-lang#147787

r? `@oli-obk`
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
700fbeb 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang/rust#142339 (Add NonNull pattern types)
 - rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang/rust#147788 (const Cell methods)
 - rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang/rust#147933 (os_str: Make platform docs more consistent)
 - rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
16b51d1 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang/rust#142339 (Add NonNull pattern types)
 - rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang/rust#147788 (const Cell methods)
 - rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang/rust#147933 (os_str: Make platform docs more consistent)
 - rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
58cebee 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang/rust#142339 (Add NonNull pattern types)
 - rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang/rust#147788 (const Cell methods)
 - rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang/rust#147933 (os_str: Make platform docs more consistent)
 - rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

6 participants

@clarfonthey @rustbot @rust-log-analyzer @oli-obk @bors @matthiaskrgr